Improvements to redfish exporter v2 for Dell systems #1549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Compatability with Dell servers - Added health round up panels - Add variables for different groups e.g overcloud vs compute
Prometheus will regard metrics collected over this perioid as stale as such they won't show up in grafana.
product-auto-label
bot
added
size: l
monitoring
jovial
commented
Feb 28, 2025
etc/kayobe/kolla/globals.yml
Outdated
| @@ -26,7 +26,7 @@ kolla_image_tags: | |||
| # Monitoring and alerting related settings | |||
|
|
|||
| opensearch_heap_size: 8g | |||
| prometheus_cmdline_extras: "--storage.tsdb.retention.time=30d" | |||
| prometheus_cmdline_extras: "--storage.tsdb.retention.time=30d --query.lookback-delta=15m" | |||
There was a problem hiding this comment.
We could something fancier like twice the longest scrape interval.
The redfish dashboard was updated to use a new UUID, however this caused errors in the Grafana logs and Grafana didn't update the dashboard. Reverting this to the old UUID fixes the issue.
m-bull
force-pushed
the
bugfix/edfish-exporter-2.0/dell
branch
from
cc2c5e5 to
15e2cba
Compare
JohnGarbutt
reviewed
Mar 10, 2025
etc/kayobe/stackhpc-monitoring.yml
Outdated
| ############################################################################### | ||
| # Prometheus server configuration | ||
|
|
||
| stackhpc_prometheus_query_lookback_delta: "{{ [redfish_exporter_scrape_interval, stackhpc_os_capacity_scrape_interval, 300] | max }}s" |
There was a problem hiding this comment.
Do you need to add a few seconds here to avoid some of the edge effects you saw in testing?
There was a problem hiding this comment.
I am also wonder if we need to change the openstack exporter threshold to be included in here as well. For larger clouds, its probably a bit too aggressive by default.
There was a problem hiding this comment.
I've added 30 seconds to give some leeway. Have also added an openstack exporter scrape interval variable and added it the max calculation.
JohnGarbutt
reviewed
Mar 10, 2025
| @@ -26,7 +26,7 @@ kolla_image_tags: | |||
| # Monitoring and alerting related settings | |||
|
|
|||
| opensearch_heap_size: 8g | |||
| prometheus_cmdline_extras: "--storage.tsdb.retention.time=30d" | |||
| prometheus_cmdline_extras: "--storage.tsdb.retention.time=30d --query.lookback-delta={{ stackhpc_prometheus_query_lookback_delta }}" | |||
There was a problem hiding this comment.
FWIW, I am +1 tweaking this, given we regularly increase the interval for various exporters.
Alex-Welsh
reviewed
Apr 1, 2025
Comment on lines
+11
to
+14
| - | | ||
| Sets the prometheus server side option ``query.lookback-delta`` to | ||
| the largest scrape interval so that metrics are not from exporters | ||
| with large scrape intervals are not marked stale before the next scrape. |
There was a problem hiding this comment.
Suggested change
| - | | |
| Sets the prometheus server side option ``query.lookback-delta`` to | |
| the largest scrape interval so that metrics are not from exporters | |
| with large scrape intervals are not marked stale before the next scrape. | |
| - | | |
| Sets the prometheus server side option ``query.lookback-delta`` to | |
| the largest scrape interval so that metrics from exporters with large | |
| scrape intervals are not marked stale before the next scrape. |
| # Whether the redfish exporter is enabled. | ||
| stackhpc_enable_redfish_exporter: false | ||
|
|
||
| # How often to scrape the BMCs in seconds. | ||
| stackhpc_redfish_exporter_scrape_interval: "{{ [8 * groups['redfish_exporter_targets'] | length, 300] | max }}" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.