Add defaults for GPU PCI passthrough #1586
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-Welsh
force-pushed
the
pci-passthrough-defaults
branch
from
115d514 to
8a06ffb
Compare
Alex-Welsh
force-pushed
the
pci-passthrough-defaults
branch
from
0856eb0 to
9cd7720
Compare
|
This should be using the stackhpc.linux collection if possible: stackhpc/ansible-collection-linux#28 |
MoteHue
reviewed
Apr 7, 2025
MoteHue
requested changes
Apr 7, 2025
Alex-Welsh
commented
Apr 7, 2025
MoteHue
requested changes
Apr 7, 2025
Alex-Welsh
commented
Apr 8, 2025
There was a problem hiding this comment.
This file may fit better under configuration/ than operations/. Opinions welcome
Alex-Welsh
force-pushed
the
pci-passthrough-defaults
branch
from
2c3562c to
bbd2eaa
Compare
Agreed, though I'd rather get this merged so we can start using it, then update once the collection supports it |
Alex-Welsh
changed the title
|
I tried out the changes on a client deployment with three GPU types, worked very well |
MoteHue
requested changes
Apr 9, 2025
Comment on lines
+73
to
+76
| Once host configuration is complete, deploy the OpenStack services: | ||
| .. code-block:: console | ||
|
|
||
| kayobe overcloud service deploy -kt nova --kolla-limit compute_a100,compute_v100,compute_multi_gpu |
There was a problem hiding this comment.
Suggested change
| Once host configuration is complete, deploy the OpenStack services: | |
| .. code-block:: console | |
| kayobe overcloud service deploy -kt nova --kolla-limit compute_a100,compute_v100,compute_multi_gpu | |
| Once host configuration is complete, deploy Nova: | |
| .. code-block:: console | |
| kayobe overcloud service deploy -kt nova |
Needs to target the controllers for Nova scheduler too.
Comment on lines
+87
to
+89
| This can be also defined in the openstack-config repository | ||
|
|
||
| add extra_specs to flavor in etc/openstack-config/openstack-config.yml: |
There was a problem hiding this comment.
Suggested change
| This can be also defined in the openstack-config repository | |
| add extra_specs to flavor in etc/openstack-config/openstack-config.yml: | |
| This can be also defined in the openstack-config repository. | |
| Add extra_specs to flavor in etc/openstack-config/openstack-config.yml: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is designed to drastically simplify pci passthrough GPU configuration.
The idea is that we have a data dictionary containing common GPU types, and templating to write that data to nova config files based on a simple group-to-gpu map.
Configuring passthrough is as simple as creating a dictionary like this:
(and passing through the group names to Kolla-Ansible)
The
pci-passthrough.ymlplaybook manages host configuration (and is pre-hooked to overcloud host configure)Templates for
nova-compute.conf,nova-api.conf, andnova-scheduler.confhave been added.Changes have now been tested in a prod environment