Skip to content

fix: use new property format for port group playbook - #2595

Merged
Alex-Welsh merged 1 commit into
stackhpc/2026.1from
fix-port-group-query
Sep 11, 2026
Merged

fix: use new property format for port group playbook#2595
Alex-Welsh merged 1 commit into
stackhpc/2026.1from
fix-port-group-query

Conversation

@jackhodgkiss

Copy link
Copy Markdown
Contributor

It has been noticed in 2026.1 deployments that the playbook for adding new port groups will fail as the properties returned are no longer uppercase and use spaces instead they are now lowercase with underscores.

It has been noticed in `2026.1` deployments that the playbook for adding
new port groups will fail as the properties returned are no longer
uppercase and use spaces instead they are now lowercase with
underscores.

Signed-off-by: Jack Hodgkiss <jack@stackhpc.com>
@jackhodgkiss
jackhodgkiss requested a review from a team as a code owner September 11, 2026 14:15
@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: fd9dc5d2-f218-40d1-bb56-508716218541

📥 Commits

Reviewing files that changed from the base of the PR and between 6a4d547 and 76a4b61.

📒 Files selected for processing (2)
  • etc/kayobe/environments/baremetal/ansible/add-port-groups.yml
  • releasenotes/notes/fix-port-group-query-62819a48038b06b4.yaml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (4)
  • GitHub Check: stackhpc/check
  • GitHub Check: Ansible 2.20 lint with Python 3.12
  • GitHub Check: Tox releasenotes with Python 3.12
  • GitHub Check: Ansible 2.19 lint with Python 3.12
🧰 Additional context used
🪛 Checkov (3.3.13)
etc/kayobe/environments/baremetal/ansible/add-port-groups.yml

[low] 41-133: Ensure block is handling task errors properly

(CKV2_ANSIBLE_3)

🔇 Additional comments (2)
etc/kayobe/environments/baremetal/ansible/add-port-groups.yml (1)

66-66: LGTM!

releasenotes/notes/fix-port-group-query-62819a48038b06b4.yaml (1)

1-6: LGTM!


📝 Summary

Updates the add-port-groups playbook to query Ironic’s lowercase, underscore-separated port group properties. This supports 2026.1 deployments and prevents failures when the playbook adds new port groups. Adds a release note documenting the fix.

Walkthrough

The add-port-groups playbook now uses Ironic's lowercase JSON field names for port filtering. A release note documents the correction.

Changes

Port group query correction

Layer / File(s) Summary
Update port filtering query and document the change
etc/kayobe/environments/baremetal/ansible/add-port-groups.yml, releasenotes/notes/fix-port-group-query-62819a48038b06b4.yaml
The query now matches physical_network, uuid, and address, and reads portgroup_uuid. The release note records the lowercase underscore-separated property names.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to 76a4b

The playbook correction is narrowly scoped and should restore port-group creation for 2026.1 deployments.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Alex-Welsh
Alex-Welsh merged commit 362c4cf into stackhpc/2026.1 Sep 11, 2026
28 checks passed
@Alex-Welsh
Alex-Welsh deleted the fix-port-group-query branch September 11, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-review PR is waiting for a review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants