-
Notifications
You must be signed in to change notification settings - Fork 15
Allow egress ips on managedseeds #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Allow egress ips on managedseeds #207
Conversation
Signed-off-by: Justin Lamp <[email protected]>
hown3d
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
I'd like to propose some changes.
9ec0e20 to
99cacca
Compare
|
I was just thinking about wether we should add a check to only add the seed CIDR if the blackbox exporter is actually deployed. @timebertt WDYT? |
Signed-off-by: Justin Lamp <[email protected]>
99cacca to
4fc2342
Compare
I would not know how to implement this. How would I get a hold of the gardenlet configuration to check it? |
|
I'm curious: Can you outline your setup in detail?
|
What this PR does / why we need it:
With this PR the Controller will automatically allow the egress IPs of the ManagedSeed. This will fix the blackbox exporter check that tries to externally access the shoots API.
Special notes for your reviewer:
The ConfigMap called
shoot-infowill be present in Seed clusters that are itself shoots. So it will only work on ManagedSeed(-Sets).