Skip to content

Conversation

marceljk
Copy link
Contributor

Description

issue: the routing table resources will not be recreated if the default_region changes

relates to STACKITTPR-350

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@marceljk marceljk requested a review from a team as a code owner September 24, 2025 12:37
Copy link

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaasalpha/routingtable/route 15.85% (-1.02%) 👎
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaasalpha/routingtable/table 17.37% (-1.14%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaasalpha/routingtable/route/resource.go 19.18% (-1.51%) 219 (+16) 42 177 (+16) 👎
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaasalpha/routingtable/table/resource.go 15.58% (-1.36%) 199 (+16) 31 168 (+16) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@marceljk marceljk merged commit 16446d7 into main Sep 24, 2025
5 checks passed
@marceljk marceljk deleted the fix/STACKITTPR-350-changing-default-region-does-not-recreate-routing-tables branch September 24, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants