Skip to content

docs: improve contribution docs #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 25, 2025
Merged

docs: improve contribution docs #1008

merged 3 commits into from
Sep 25, 2025

Conversation

marceljk
Copy link
Contributor

Description

relates to STACKITTPR-317

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@marceljk marceljk requested a review from a team as a code owner September 25, 2025 12:57
@marceljk marceljk force-pushed the docs/STACKITTPR-317-improve-contribution-docs branch from 2ee8736 to 63d0c96 Compare September 25, 2025 14:06
@marceljk marceljk force-pushed the docs/STACKITTPR-317-improve-contribution-docs branch from 63d0c96 to 0b24296 Compare September 25, 2025 14:07
rubenhoenle
rubenhoenle previously approved these changes Sep 25, 2025
View reviewed changes
Copy link
Member

@rubenhoenle rubenhoenle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider this as nitpicks, looks great overall. Thanks for your efforts! 😊

@marceljk marceljk force-pushed the docs/STACKITTPR-317-improve-contribution-docs branch from 3b8ab7f to 94efbc2 Compare September 25, 2025 15:12
@github-actions GitHub Actions
Copy link

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/ske 0.00% (ø)
Coverage by file

Changed unit test files

  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/ske/ske_acc_test.go

@rubenhoenle rubenhoenle enabled auto-merge (squash) September 25, 2025 15:32
@rubenhoenle rubenhoenle merged commit 4289012 into main Sep 25, 2025
5 checks passed
@rubenhoenle rubenhoenle deleted the docs/STACKITTPR-317-improve-contribution-docs branch September 25, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubenhoenle rubenhoenle rubenhoenle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marceljk @rubenhoenle