Skip to content

Commit

Permalink
feat: make "setup" menu section less confusing (#81)
Browse files Browse the repository at this point in the history
commit 55b0745
Author: Daniel Kantor <[email protected]>
Date:   Wed Jan 15 15:01:35 2025 +0100

    chore: add prettier

commit b610317
Author: Daniel Kantor <[email protected]>
Date:   Wed Jan 15 14:50:49 2025 +0100

    refactor: extract <DropdownMenuItem />

commit d3513aa
Author: Daniel Kantor <[email protected]>
Date:   Wed Jan 15 14:48:06 2025 +0100

    refactor: extract <DropdownMenu />

commit 9eb2021
Author: Daniel Kantor <[email protected]>
Date:   Wed Jan 15 14:44:34 2025 +0100

    refactor: extract <HeaderMenuItem />
  • Loading branch information
kantord authored Jan 15, 2025
1 parent 9d2f2ce commit ae42046
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions src/App.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ describe("App", () => {
render(<App />);
expect(screen.getByText(/toggle sidebar/i)).toBeVisible();
expect(screen.getByText("Certificates")).toBeVisible();
expect(screen.getByText("Help")).toBeVisible();
expect(screen.getByText("Setup")).toBeVisible();
expect(screen.getByRole("banner")).toBeVisible();
expect(
screen.getByRole("heading", { name: /codeGate dashboard/i }),
Expand All @@ -31,13 +31,13 @@ describe("App", () => {
).toBeVisible();
expect(
screen.getByRole("link", {
name: /continue setup/i,
name: /set up in continue/i,
}),
).toBeVisible();

expect(
screen.getByRole("link", {
name: /copilot setup/i,
name: /set up in copilot/i,
}),
).toBeVisible();
expect(
Expand Down
6 changes: 3 additions & 3 deletions src/components/Header.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -63,13 +63,13 @@ export function Header({ hasError }: { hasError?: boolean }) {
</div>

<div className="flex items-center relative group">
<HeaderMenuItem>Help</HeaderMenuItem>
<HeaderMenuItem>Setup</HeaderMenuItem>
<DropdownMenu>
<DropdownMenuItem to="/help/continue-setup">
Continue Setup
Set up in <span className="font-bold">Continue</span>
</DropdownMenuItem>
<DropdownMenuItem to="/help/copilot-setup">
Copilot Setup
Set up in <span className="font-bold">Copilot</span>
</DropdownMenuItem>
</DropdownMenu>
</div>
Expand Down

0 comments on commit ae42046

Please sign in to comment.