fix: Do not double count secrets on /explain copilot function
#581
+19
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: #519 When using `/explain` function in copilot we were double counting th secrets. The problem was that we were getting several `user` messages after the last `assistant` message. We are using the last `assistant` message as means to identify the user messages. Here is an example of how the request looked like for `/explain`: ``` [ {"role": "assistant", "content": "some content"}, {"role": "user", "content": content_with_secrets}, {"role": "user", "content": content_with_secrets}, ] ``` To avoid double counting now we check which was the secrets that matched after the last `assistant` message and only consider the unique ones.
jhrozek
reviewed
Jan 14, 2025
| @@ -371,8 +373,6 @@ async def process_chunk( | |||
| if original_value is None: | |||
| # If value not found, leave as is | |||
| original_value = match.group(0) # Keep the REDACTED marker | |||
| else: | |||
There was a problem hiding this comment.
oops sorry this is some leftover debugging by me
There was a problem hiding this comment.
Yes, I assumed so. No problem :)
jhrozek
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #519
When using
/explainfunction in copilot we were double counting th secrets. The problem was that we were getting severalusermessages after the lastassistantmessage. We are using the lastassistantmessage as means to identify the user messages. Here is an example of how the request looked like for/explain:To avoid double counting now we check which was the secrets that matched after the last
assistantmessage and only consider the unique ones.