Add all-in-one minimal nginx config #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The nginx configuration uses a lot of defaults that work well in server-like environments. However, this is not optimized for a local dev-environment or single-container as codegate is meant to run. The nginx server spawns several processes which mostly remain idle. This is wasteful and it is taking over resources that could be used for something else. The intention of this new configuration is to minimize footprint. Signed-off-by: Juan Antonio Osorio <[email protected]>
jhrozek
reviewed
Jan 15, 2025
| @@ -78,7 +78,7 @@ RUN chown -R codegate /var/lib/nginx && \ | |||
| chown -R codegate /var/log/nginx && \ | |||
| chown -R codegate /run | |||
|
|
|||
| COPY nginx.conf /etc/nginx/conf.d/default.conf | |||
| COPY nginx.conf /etc/nginx/nginx.conf | |||
There was a problem hiding this comment.
is there any system-default nginx.conf? Which of them takes precedence? Just making sure we won't block ourselves from receiving changes to defaults in the future
There was a problem hiding this comment.
right, that's exactly what I'm overwriting here. We no longer take into account the default nginx.conf and instead write our own.
jhrozek
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nginx configuration uses a lot of defaults that work well in
server-like environments. However, this is not optimized for a local
dev-environment or single-container as codegate is meant to run.
The nginx server spawns several processes which mostly remain idle. This
is wasteful and it is taking over resources that could be used for
something else. The intention of this new configuration is to minimize
footprint.
Signed-off-by: Juan Antonio Osorio [email protected]