Initial CRUD API for workspaces #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAORMX
requested review from
aponcedeleonch,
lukehinds and
jhrozek
and removed request for
aponcedeleonch
JAORMX
force-pushed
the
workspace-api
branch
2 times, most recently
from
a180108 to
2cf1dda
Compare
lukehinds
reviewed
Jan 17, 2025
aponcedeleonch
previously approved these changes
Jan 17, 2025
aponcedeleonch
previously approved these changes
Jan 17, 2025
JAORMX
force-pushed
the
workspace-api
branch
2 times, most recently
from
b73e08e to
a668d57
Compare
I'm already doing this, we actually have See: Versioning APIs is a best practice which I like to follow 😄 |
This adds a simple and unimplemented REST API for workspaces. Workspaces will be the base for all other resources in terms of REST resource mapping, so these go first. These are initially left entirely unimplemented as stacklok#600 needs to merge Signed-off-by: Juan Antonio Osorio <[email protected]>
aponcedeleonch
approved these changes
Jan 17, 2025
JAORMX
added a commit
to JAORMX/codegate
that referenced
this pull request
Jan 17, 2025
stacklok#633 accidentally deleted some functions that were introduced by stacklok#620 This re-introduces them. Signed-off-by: Juan Antonio Osorio <[email protected]>
JAORMX
added a commit
that referenced
this pull request
Jan 17, 2025
#633 accidentally deleted some functions that were introduced by #620 This re-introduces them. Signed-off-by: Juan Antonio Osorio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a simple and unimplemented REST API for workspaces. Workspaces
will be the base for all other resources in terms of REST resource
mapping, so these go first.
These are initially left entirely unimplemented as
#600 needs to merge
Signed-off-by: Juan Antonio Osorio [email protected]