This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Fix issue with utm_source not appearing in generated insight links #766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lukehinds @yrobla I know there is still a lot of manual testing going on. I verified this change locally with the image now for copilot, but we may want to regression test in the other codegen tools. Tests pass and the behavior is as expected, but I don't know for sure if we are making assumptions about the insight link formats anywhere that isn't explicitly tested. |
JAORMX
approved these changes
Jan 25, 2025
lukehinds
pushed a commit
that referenced
this pull request
Jan 31, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #765