Fix resource leak in session storage cleanup

[yrobla]

Implements fix by calling Close() on sessions that implement io.Closer before deleting them from storage during cleanup. This prevents connection leaks when vMCP sessions with backend clients expire.

Closes: #3871

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3d8dad4ce9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[Copilot]

Pull request overview

Fixes session-expiry resource leaks by ensuring expiring sessions that own resources are closed before removal from in-memory storage, with accompanying unit tests validating the new cleanup behavior.

Changes:

• Update LocalStorage.DeleteExpired() to call Close() on sessions that implement io.Closer before deleting them.
• Add unit tests covering io.Closer sessions, non-closer sessions, and Close() error handling.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
pkg/transport/session/storage_local.go	Adds io.Closer detection and Close() invocation during expired-session cleanup, with warning logs on close failure.
pkg/transport/session/storage_test.go	Introduces a closable mock session and adds test cases for closer/non-closer deletion and close-error behavior.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codecov]

Codecov Report

❌ Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.69%. Comparing base (0791876) to head (28bc450).
⚠️ Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/transport/session/storage_local.go	89.47%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4014      +/-   ##
==========================================
+ Coverage   68.62%   68.69%   +0.06%     
==========================================
  Files         445      445              
  Lines       45374    45389      +15     
==========================================
+ Hits        31140    31182      +42     
+ Misses      11827    11804      -23     
+ Partials     2407     2403       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.