Skip to content

Add special handling for running the detached process on Windows #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 23, 2025

Conversation

rdimitrov
Copy link
Member

@rdimitrov rdimitrov commented May 23, 2025

The following fixes the issue during building ToolHive for Windows -

# github.com/stacklok/toolhive/pkg/lifecycle
pkg\lifecycle\manager.go:316:3: unknown field Setsid in struct literal of type syscall.SysProcAttr

It also enables Goreleaser to build and ship for Windows.

I've tested it with -

GOOS=windows GOARCH=amd64 go build ./cmd/thv/

Related to: #129

@rdimitrov rdimitrov merged commit d9c2014 into main May 23, 2025
11 checks passed
@rdimitrov rdimitrov deleted the fix-windows branch May 23, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants