Skip to content

ROX-27947: Disable scraper for repeated network test #2080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

erthalion
Copy link
Contributor

@erthalion erthalion commented Apr 10, 2025

Description

Test.

Checklist

  • Investigated and inspected CI test results
  • Updated documentation accordingly

Automated testing

  • Added unit tests
  • Added integration tests
  • Added regression tests

If any of these don't apply, please comment below.

Testing Performed

Manual tests.

Summary by Sourcery

Add configuration to disable scraping in repeated network flow tests

Enhancements:

  • Introduced a new configuration parameter 'TurnOffScrape' to control scraping behavior in network flow test suites

Tests:

  • Modified integration tests to support optional scraping disablement
  • Updated test suite configuration to include new scraping control parameter

Copy link

sourcery-ai bot commented Apr 10, 2025

Reviewer's Guide by Sourcery

This pull request introduces a TurnOffScrape field to the RepeatedNetworkFlowTestSuite struct, allowing the disabling of scraping in repeated network flow tests. This change was implemented by adding the TurnOffScrape field to the struct and using it in the test suite configuration. The TestRepeatedNetworkFlowThreeCurlsNoAfterglow test was modified to disable scraping.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added a TurnOffScrape field to the RepeatedNetworkFlowTestSuite struct and used it to control whether scraping is enabled in the tests.
  • Added TurnOffScrape field to RepeatedNetworkFlowTestSuite struct.
  • Added TurnOffScrape field to the test suite configuration.
  • Modified TestRepeatedNetworkFlowThreeCurlsNoAfterglow to disable scraping.
integration-tests/integration_test.go
integration-tests/suites/repeated_network_flow.go

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.51%. Comparing base (feaaf30) to head (75b3bf5).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2080      +/-   ##
==========================================
+ Coverage   27.48%   27.51%   +0.02%     
==========================================
  Files          93       93              
  Lines        5733     5727       -6     
  Branches     2539     2533       -6     
==========================================
  Hits         1576     1576              
+ Misses       3490     3484       -6     
  Partials      667      667              
Flag Coverage Δ
collector-unit-tests 27.51% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erthalion erthalion force-pushed the fix/turn-off-scraper-for-repeated-network-test branch from 8840370 to 23a7c44 Compare April 11, 2025 09:37
@erthalion erthalion force-pushed the fix/turn-off-scraper-for-repeated-network-test branch from 23a7c44 to 75b3bf5 Compare April 11, 2025 13:49
@erthalion erthalion changed the title Disable scraper for repeated network test ROX-27947: Disable scraper for repeated network test Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants