Skip to content

Revert GH arm changes #2107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 26, 2025
Merged

Revert GH arm changes #2107

merged 2 commits into from
Apr 26, 2025

Conversation

robbycochran
Copy link
Collaborator

@robbycochran robbycochran commented Apr 26, 2025

Description

exclude for ppc64le isn't working from #2084

Checklist

  • Investigated and inspected CI test results
  • Updated documentation accordingly

Automated testing

  • Added unit tests
  • Added integration tests
  • Added regression tests

If any of these don't apply, please comment below.

Testing Performed

TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why you did not do so. (Valid reasons include "CI is sufficient" or "No testable changes")
In addition to reviewing your code, reviewers must also review your testing instructions, and make sure they are sufficient.

For more details, ref the Confluence page about this section.

@robbycochran robbycochran marked this pull request as ready for review April 26, 2025 03:51
@robbycochran robbycochran requested a review from a team as a code owner April 26, 2025 03:51
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @robbycochran - I've reviewed your changes - here's some feedback:

Overall Comments:

  • This revert removes ARM from the unit test matrix; confirm if this is the intended behavior.
  • Building ARM images on amd64 runners using emulation might significantly increase build times compared to using native ARM runners.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.40%. Comparing base (d562819) to head (4d67e7b).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2107   +/-   ##
=======================================
  Coverage   28.40%   28.40%           
=======================================
  Files          94       94           
  Lines        5717     5717           
  Branches     2531     2531           
=======================================
  Hits         1624     1624           
  Misses       3383     3383           
  Partials      710      710           
Flag Coverage Δ
collector-unit-tests 28.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robbycochran robbycochran merged commit 61cd323 into master Apr 26, 2025
78 of 81 checks passed
@robbycochran robbycochran deleted the rc-revert-gh-arm branch April 26, 2025 22:45
robbycochran added a commit that referenced this pull request Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants