Skip to content

feature(lint): Add linter to priorityClassName #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jonathanmdr
Copy link
Contributor

@jonathanmdr jonathanmdr commented Mar 13, 2025

This pull request introduces a new check for validating priority class names in Kubernetes objects. The changes include the addition of a new template, corresponding parameters, and test cases. The most important changes are summarized below:

Issues:

New Template and Parameters:

Test Cases:

Configuration and Integration:

E2E Tests:

@jonathanmdr
Copy link
Contributor Author

Hi @rhybrillou and @janisz!

Can you spend some time reviewing this PR?

If there's any feedback about this approach, I will be happy to follow up on it. 😄

@janisz janisz self-assigned this Mar 21, 2025
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

Attention: Patch coverage is 52.50000% with 19 lines in your changes missing coverage. Please review.

Project coverage is 28.64%. Comparing base (dbd7529) to head (0010896).
Report is 108 commits behind head on main.

Files with missing lines Patch % Lines
...es/priorityclassname/internal/params/gen-params.go 0.00% 19 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #926       +/-   ##
===========================================
- Coverage   62.36%   28.64%   -33.72%     
===========================================
  Files         197      203        +6     
  Lines        4854     5872     +1018     
===========================================
- Hits         3027     1682     -1345     
- Misses       1439     4075     +2636     
+ Partials      388      115      -273     
Flag Coverage Δ
unit 28.64% <52.50%> (-33.72%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jonathanmdr jonathanmdr force-pushed the main branch 7 times, most recently from af814c2 to 13ca337 Compare April 11, 2025 03:58
@jonathanmdr
Copy link
Contributor Author

jonathanmdr commented Apr 11, 2025

Hi @janisz and @rhybrillou, can you help me understand the codecov/patch behaviour?

When I opened the PR, this step passed successfully, but after I rebased the branch with the latest changes merged on the main branch, it started failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE_REQUEST] Need check for priorityClassName value
2 participants