Skip to content

Conversation

@wileyj wileyj requested review from a team April 1, 2025 16:49
@wileyj wileyj moved this to Status: 💻 In Progress in Stacks Core Eng Apr 1, 2025
@wileyj wileyj added the CI label Apr 1, 2025
@wileyj wileyj added this to the 3.1.0.0.8 milestone Apr 1, 2025
obycode
obycode previously approved these changes Apr 1, 2025
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@aldur aldur requested a review from fdefelici April 1, 2025 17:33
wileyj
wileyj previously approved these changes Apr 1, 2025
Copy link
Collaborator

@wileyj wileyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - waiting on @fdefelici for any comments

@wileyj wileyj changed the title Replace GitHub Token Secret From CI Update ci workflow Apr 1, 2025
Copy link
Contributor

@fdefelici fdefelici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just added a comment about the github token

@BowTiedDevOps BowTiedDevOps dismissed stale reviews from wileyj and obycode via 2329139 April 2, 2025 13:49
@BowTiedDevOps
Copy link
Contributor Author

Successful run after changing the token's name: https://github.com/BowTiedDevOps/stacks-core/actions/runs/14220729493

@aldur aldur requested review from fdefelici, obycode and wileyj April 2, 2025 13:52
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wileyj wileyj enabled auto-merge April 2, 2025 13:59
@wileyj wileyj added this pull request to the merge queue Apr 2, 2025
Merged via the queue into stacks-network:develop with commit ecf6147 Apr 2, 2025
1 check passed
@github-project-automation github-project-automation bot moved this from Status: 💻 In Progress to Status: ✅ Done in Stacks Core Eng Apr 2, 2025
@wileyj wileyj mentioned this pull request Apr 11, 2025
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

Status: Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

5 participants