Setup for Clarity 4 and implement contract-hash?
#6403
+2,770
−464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See clarity-lang/reference#88 and stacks-network#6320 for dicsussion about this new builtin function.
For now, this is only accessible via the CLI: ```sh stacks-inspect contract-hash <path-to-contract> ```
Also adds Epoch 3.3 and costs-4 to support this new function and removes the MAST implementation from the previous proposal.
This is not needed since it will actually execute a read-only call in the Clarity version for the called contract. Removing this allows us to safely set `ClarityVersion::latest()` to return `Clarity4`.
Fix issues with different Clarity versions and add some more fake results from the test DBs.
|
These failing integration tests all pass locally. I don't recall seeing these be flaky in other PRs. I will take a look to see if I introduced a new source of flakiness somewhere. |
|
I believe the flakiness I saw before is solved by #6420. |
kantai
reviewed
Aug 28, 2025
kantai
reviewed
Aug 28, 2025
kantai
reviewed
Aug 28, 2025
Will be updated to 3.3 once all of 3.3 is implemented.
kantai
previously approved these changes
Sep 3, 2025
hstove
previously approved these changes
Sep 3, 2025
kantai
previously approved these changes
Sep 3, 2025
hstove
previously approved these changes
Sep 3, 2025
|
What I've come up with is to do this in memo: if cfg!(test) && target_epoch.epoch_id > StacksEpochId::latest() {
vec![marker_for_epoch(target_epoch.epoch_id).expect("Unsupported epoch")]
} else {
vec![STACKS_EPOCH_LATEST_MARKER]
}, |
Also harden the `test_epoch_3_3_activation` test a bit.
Actually, I realized just have a test version of |
The test implementation returns epoch 3.3 while the non-test version returns 3.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the first step in the Clarity 4 proposal (see SIP PR #218). This changes adds Epoch 3.3, Clarity version 4, and costs-4, which is needed for the new builtins. Epoch 3.3 is currently set to activate at Bitcoin height 33,000,000, and Clarity 4 does not activate until 3.3, so it should be safe to merge into develop.
Checklist
docs/rpc/openapi.yamlandrpc-endpoints.mdfor v2 endpoints,event-dispatcher.mdfor new events)clarity-benchmarkingrepo