Skip to content

Conversation

@jacinta-stacks
Copy link
Contributor

@jacinta-stacks jacinta-stacks commented Dec 5, 2025

@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

❌ Patch coverage is 49.55157% with 225 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.04%. Comparing base (4f535d8) to head (6258388).

Files with missing lines Patch % Lines
stacks-node/src/tests/signer/v0.rs 30.86% 215 Missing ⚠️
libsigner/src/v0/messages.rs 91.74% 9 Missing ⚠️
stacks-node/src/tests/signer/mod.rs 94.11% 1 Missing ⚠️

❌ Your project check has failed because the head coverage (78.04%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6742      +/-   ##
===========================================
+ Coverage    77.77%   78.04%   +0.26%     
===========================================
  Files          585      585              
  Lines       361916   362206     +290     
===========================================
+ Hits        281498   282695    +1197     
+ Misses       80418    79511     -907     
Files with missing lines Coverage Δ
stacks-signer/src/v0/signer_state.rs 75.18% <100.00%> (+0.21%) ⬆️
stacks-node/src/tests/signer/mod.rs 68.72% <94.11%> (-5.52%) ⬇️
libsigner/src/v0/messages.rs 84.77% <91.74%> (-1.86%) ⬇️
stacks-node/src/tests/signer/v0.rs 22.93% <30.86%> (+1.42%) ⬆️

... and 79 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f535d8...6258388. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

… version and update tests

Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
…sage from a lagging signer

Signed-off-by: Jacinta Ferrant <[email protected]>
Copy link
Contributor

@aaronb-stacks aaronb-stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changeset looks good to me, but I think we can't merge global signer state machine activation to develop before we've concluded mainnet testing of the signer state machine.

jacinta-stacks and others added 9 commits January 2, 2026 07:15
…ncrease to new signer version.

Signed-off-by: Jacinta Ferrant <[email protected]>
* add `/v3/tenures/tip_metadata` for obtaining burn_view metadata, with openapi spec
* correct the signer burn_view calculations, with e2e tests
…burn-view

Fix: burn view calculations in signer
Signed-off-by: Jacinta Ferrant <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants