fix: do not double hash in secp256r1-verify
#6763
66.83% (target 80.00%)
View this Pull Request on Codecov
66.83% (target 80.00%)
Details
Codecov Report
❌ Patch coverage is 65.57377% with 42 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.83%. Comparing base (3da96c1) to head (282a71d).
| Files with missing lines | Patch % | Lines |
|---|---|---|
| clarity/src/vm/tests/crypto.rs | 0.00% | 37 Missing |
| stacks-common/src/util/secp256r1.rs | 94.73% | 4 Missing |
| clarity/src/vm/functions/crypto.rs | 80.00% | 1 Missing |
❌ Your project check has failed because the head coverage (66.83%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.
❗ There is a different number of reports uploaded between BASE (3da96c1) and HEAD (282a71d). Click for more details.
Additional details and impacted files
@@ Coverage Diff @@
## develop #6763 +/- ##
============================================
- Coverage 78.18% 66.83% -11.35%
============================================
Files 580 585 +5
Lines 361096 361965 +869
============================================
- Hits 282312 241918 -40394
- Misses 78784 120047 +41263 | Files with missing lines | Coverage Δ | |
|---|---|---|
| clarity/src/vm/docs/mod.rs | 82.16% <ø> (-8.58%) |
⬇️ |
| clarity/src/vm/version.rs | 66.66% <100.00%> (-17.55%) |
⬇️ |
| clarity/src/vm/functions/crypto.rs | 77.64% <80.00%> (-0.22%) |
⬇️ |
| stacks-common/src/util/secp256r1.rs | 66.40% <94.73%> (-21.06%) |
⬇️ |
| clarity/src/vm/tests/crypto.rs | 67.85% <0.00%> (-30.91%) |
⬇️ |
... and 317 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 3da96c1...282a71d. Read the comment docs.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.