refactor: remove the ability to use event dispatcher without DB #6785
+222
−223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ability was only used during tests; in actual production, there is always a DB. Not having to support the DB-less use is going to make it a lot cleaner to use the DB as a queue (see stacks-network#6543). This commit also makes the method names and order of operations a little less confusing -- we had `send_payload()`, `send_payload_directly()`, `send_payload_given_db_path()` (ok that one was my fault), and `send_payload_with_bytes()`. Now we have this instead: ``` dispatch_to_observer() -> get_payload_bytes() -> save_to_db() -> make_http_request_and_delete_from_db() -> make_http_request() -> delete_from_db() ```
benjamin-stacks
requested review from
aaronb-stacks,
brice-stacks and
jacinta-stacks
jacinta-stacks
approved these changes
Jan 7, 2026
benjamin-stacks
commented
Jan 9, 2026
| DbError(stacks::util_lib::db::Error), | ||
| } | ||
|
|
||
| impl fmt::Display for EventDispatcherError { |
Author
Merged
via the queue into
stacks-network:develop
with commit Jan 9, 2026
4f535d8
1234 of 1240 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another PR I'm splitting out of #6762 since this commit is very self-contained.
The ability to have the event dispatcher not use the database was only used during tests; in actual production, there is always a DB.
Not having to support the DB-less use is going to make it a lot cleaner to use the DB as a (required) queue (see #6543).
This commit also makes the method names and order of operations a little less confusing -- we had
send_payload(),send_payload_directly(),send_payload_given_db_path()(ok that one was my fault), andsend_payload_with_bytes().Now we have this instead:
Reviewing notes
I've tried to keep the order of the functions in such a way that the diff has as little noise as possible, at least when you hide whitespace, which I strongly suggest).