Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove thumbnail asset hrefing preview.jpg as this asset is not alway… #144

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

philvarner
Copy link
Collaborator

…s there

Related issues

  • Closes #XXX
  • Unblocks #XXX

Description

Please describe your changes.

Checklist

  • Includes tests
  • Includes documentation
  • Updates CHANGELOG

@philvarner philvarner marked this pull request as ready for review November 22, 2023 19:11
@philvarner philvarner merged commit 42faa08 into main Nov 27, 2023
@philvarner philvarner deleted the pv/remove-thumbnail branch November 27, 2023 13:34
@ircwaves
Copy link
Collaborator

@philvarner -- scratching your memory banks a bit here, but do you recall if dropping this preview image checking was to optimize the code speed, or did the sometimes missing preview asset cause another failure?

@philvarner
Copy link
Collaborator Author

It was just because this code was always putting it, regardless of whether it was there there or not, and we didn't want to have an automatically generated broken link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants