Skip to content

test: replace Duelo Maestro with The Badland #65

test: replace Duelo Maestro with The Badland

test: replace Duelo Maestro with The Badland #65

Triggered via push January 9, 2025 21:38
Status Success
Total duration 2m 28s
Artifacts

coverage.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

73 warnings
the following explicit lifetimes could be elided: 'a: src/serde/thunk.rs#L93
warning: the following explicit lifetimes could be elided: 'a --> src/serde/thunk.rs:93:6 | 93 | impl<'a, C: ThunkProcessor> Serialize for Thunk<'a, C> | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 93 - impl<'a, C: ThunkProcessor> Serialize for Thunk<'a, C> 93 + impl<C: ThunkProcessor> Serialize for Thunk<'_, C> |
the following explicit lifetimes could be elided: 'write: src/serde/ser/request.rs#L417
warning: the following explicit lifetimes could be elided: 'write --> src/serde/ser/request.rs:417:6 | 417 | impl<'write, W: Write> serde::ser::SerializeSeq for SerializeSeq<'write, W> { | ^^^^^^ ^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 417 - impl<'write, W: Write> serde::ser::SerializeSeq for SerializeSeq<'write, W> { 417 + impl<W: Write> serde::ser::SerializeSeq for SerializeSeq<'_, W> { |
the following explicit lifetimes could be elided: 'ser: src/serde/ser/request.rs#L217
warning: the following explicit lifetimes could be elided: 'ser --> src/serde/ser/request.rs:217:6 | 217 | impl<'ser, 'a, W: Write> Serializer for &'a mut ValueSerializer<'ser, W> { | ^^^^ ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 217 - impl<'ser, 'a, W: Write> Serializer for &'a mut ValueSerializer<'ser, W> { 217 + impl<'a, W: Write> Serializer for &'a mut ValueSerializer<'_, W> { |
the following explicit lifetimes could be elided: 'ser: src/serde/ser/request.rs#L188
warning: the following explicit lifetimes could be elided: 'ser --> src/serde/ser/request.rs:188:6 | 188 | impl<'ser, W: Write> ValueSerializer<'ser, W> { | ^^^^ ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 188 - impl<'ser, W: Write> ValueSerializer<'ser, W> { 188 + impl<W: Write> ValueSerializer<'_, W> { |
the following explicit lifetimes could be elided: 'a: src/serde/ser/request.rs#L155
warning: the following explicit lifetimes could be elided: 'a --> src/serde/ser/request.rs:155:6 | 155 | impl<'a, W: Write> SerializeStruct for &'a mut RequestSerializer<W> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 155 - impl<'a, W: Write> SerializeStruct for &'a mut RequestSerializer<W> { 155 + impl<W: Write> SerializeStruct for &mut RequestSerializer<W> { |
the following explicit lifetimes could be elided: 'a: src/serde/ser/request.rs#L48
warning: the following explicit lifetimes could be elided: 'a --> src/serde/ser/request.rs:48:6 | 48 | impl<'a, W: Write> Serializer for &'a mut RequestSerializer<W> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 48 - impl<'a, W: Write> Serializer for &'a mut RequestSerializer<W> { 48 + impl<W: Write> Serializer for &mut RequestSerializer<W> { |
the following explicit lifetimes could be elided: 'a: src/serde/ser/indexed.rs#L239
warning: the following explicit lifetimes could be elided: 'a --> src/serde/ser/indexed.rs:239:6 | 239 | impl<'a, W: Write> SerializeStruct for &'a mut IndexedSerializer<W> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 239 - impl<'a, W: Write> SerializeStruct for &'a mut IndexedSerializer<W> { 239 + impl<W: Write> SerializeStruct for &mut IndexedSerializer<W> { |
the following explicit lifetimes could be elided: 'a: src/serde/ser/indexed.rs#L75
warning: the following explicit lifetimes could be elided: 'a --> src/serde/ser/indexed.rs:75:6 | 75 | impl<'a, W: Write> Serializer for &'a mut IndexedSerializer<W> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 75 - impl<'a, W: Write> Serializer for &'a mut IndexedSerializer<W> { 75 + impl<W: Write> Serializer for &mut IndexedSerializer<W> { |
the following explicit lifetimes could be elided: 'a: src/serde/de/indexed.rs#L388
warning: the following explicit lifetimes could be elided: 'a --> src/serde/de/indexed.rs:388:6 | 388 | impl<'a, 'de> de::MapAccess<'de> for MapAccess<'a, 'de> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 388 - impl<'a, 'de> de::MapAccess<'de> for MapAccess<'a, 'de> { 388 + impl<'de> de::MapAccess<'de> for MapAccess<'_, 'de> { |
the following explicit lifetimes could be elided: 'a: src/serde/de/indexed.rs#L360
warning: the following explicit lifetimes could be elided: 'a --> src/serde/de/indexed.rs:360:6 | 360 | impl<'a, 'de> de::SeqAccess<'de> for SeqAccess<'a, 'de> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 360 - impl<'a, 'de> de::SeqAccess<'de> for SeqAccess<'a, 'de> { 360 + impl<'de> de::SeqAccess<'de> for SeqAccess<'_, 'de> { |
the following explicit lifetimes could be elided: 'a: src/serde/de/indexed.rs#L130
warning: the following explicit lifetimes could be elided: 'a --> src/serde/de/indexed.rs:130:6 | 130 | impl<'a, 'de> Deserializer<'de> for &'a mut IndexedDeserializer<'de> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 130 - impl<'a, 'de> Deserializer<'de> for &'a mut IndexedDeserializer<'de> { 130 + impl<'de> Deserializer<'de> for &mut IndexedDeserializer<'de> { |
doc list item without indentation: src/serde/de/indexed.rs#L41
warning: doc list item without indentation --> src/serde/de/indexed.rs:41:5 | 41 | /// generates artificial indices (which just count up by 1 for each field) for error messages. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 41 | /// generates artificial indices (which just count up by 1 for each field) for error messages. | ++
doc list item without indentation: src/serde/de/indexed.rs#L40
warning: doc list item without indentation --> src/serde/de/indexed.rs:40:5 | 40 | /// fields has to occur based on the how many-th field they are. In this case the deserializer | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 40 | /// fields has to occur based on the how many-th field they are. In this case the deserializer | ++
doc list item without indentation: src/serde/de/indexed.rs#L38
warning: doc list item without indentation --> src/serde/de/indexed.rs:38:5 | 38 | /// unique and tells us which field follows. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 38 | /// unique and tells us which field follows. | ++
you are explicitly cloning with `.map()`: src/response.rs#L80
warning: you are explicitly cloning with `.map()` --> src/response.rs:80:24 | 80 | let song = level | ________________________^ 81 | | .custom_song 82 | | .and_then(|song_id| songs.iter().find(|song| song.song_id == song_id)) 83 | | .map(Clone::clone); | |__________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone help: consider calling the dedicated `cloned` method | 80 ~ let song = level 81 + .custom_song 82 ~ .and_then(|song_id| songs.iter().find(|song| song.song_id == song_id)).cloned(); |
you are explicitly cloning with `.map()`: src/response.rs#L79
warning: you are explicitly cloning with `.map()` --> src/response.rs:79:27 | 79 | let creator = creators.iter().find(|creator| creator.user_id == level.creator).map(Clone::clone); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `creators.iter().find(|creator| creator.user_id == level.creator).cloned()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone = note: `#[warn(clippy::map_clone)]` on by default
direct implementation of `ToString`: src/request/user.rs#L117
warning: direct implementation of `ToString` --> src/request/user.rs:117:1 | 117 | / impl ToString for UserSearchRequest<'_> { 118 | | fn to_string(&self) -> String { 119 | | super::to_string(self) 120 | | } 121 | | } | |_^ | = help: prefer implementing `Display` instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl
direct implementation of `ToString`: src/request/user.rs#L54
warning: direct implementation of `ToString` --> src/request/user.rs:54:1 | 54 | / impl ToString for UserRequest<'_> { 55 | | fn to_string(&self) -> String { 56 | | super::to_string(self) 57 | | } 58 | | } | |_^ | = help: prefer implementing `Display` instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl
direct implementation of `ToString`: src/request/level.rs#L591
warning: direct implementation of `ToString` --> src/request/level.rs:591:1 | 591 | / impl ToString for LevelsRequest<'_> { 592 | | fn to_string(&self) -> String { 593 | | super::to_string(self) 594 | | } 595 | | } | |_^ | = help: prefer implementing `Display` instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl
doc list item without indentation: src/request/level.rs#L291
warning: doc list item without indentation --> src/request/level.rs:291:5 | 291 | /// same as `0` ([`LevelRequestType::Search`]) and `6` ([`LevelRequestType::Featured`]) respectively | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 291 | /// same as `0` ([`LevelRequestType::Search`]) and `6` ([`LevelRequestType::Featured`]) respectively | ++
doc list item without indentation: src/request/level.rs#L223
warning: doc list item without indentation --> src/request/level.rs:223:9 | 223 | /// `completedLevels` is omitted. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 223 | /// `completedLevels` is omitted. | ++
doc list item without indentation: src/request/level.rs#L222
warning: doc list item without indentation --> src/request/level.rs:222:9 | 222 | /// If no completion filtering is desired, both boolean fields are set to `0` and | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 222 | /// If no completion filtering is desired, both boolean fields are set to `0` and | ++
direct implementation of `ToString`: src/request/level.rs#L92
warning: direct implementation of `ToString` --> src/request/level.rs:92:1 | 92 | / impl ToString for LevelRequest<'_> { 93 | | fn to_string(&self) -> String { 94 | | super::to_string(self) 95 | | } 96 | | } | |_^ | = help: prefer implementing `Display` instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl
direct implementation of `ToString`: src/request/comment.rs#L184
warning: direct implementation of `ToString` --> src/request/comment.rs:184:1 | 184 | / impl ToString for ProfileCommentsRequest<'_> { 185 | | fn to_string(&self) -> String { 186 | | super::to_string(self) 187 | | } 188 | | } | |_^ | = help: prefer implementing `Display` instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl
direct implementation of `ToString`: src/request/comment.rs#L116
warning: direct implementation of `ToString` --> src/request/comment.rs:116:1 | 116 | / impl ToString for LevelCommentsRequest<'_> { 117 | | fn to_string(&self) -> String { 118 | | super::to_string(self) 119 | | } 120 | | } | |_^ | = help: prefer implementing `Display` instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl = note: `#[warn(clippy::to_string_trait_impl)]` on by default
the following explicit lifetimes could be elided: 'a: src/model/song.rs#L59
warning: the following explicit lifetimes could be elided: 'a --> src/model/song.rs:59:6 | 59 | impl<'a> NewgroundsSong<'a> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 59 - impl<'a> NewgroundsSong<'a> { 59 + impl NewgroundsSong<'_> { |
doc list item without indentation: src/model/level/mod.rs#L446
warning: doc list item without indentation --> src/model/level/mod.rs:446:5 | 446 | /// index 9, dash-rs ignores this value. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 446 | /// index 9, dash-rs ignores this value. | ++
doc list item without indentation: src/model/level/mod.rs#L445
warning: doc list item without indentation --> src/model/level/mod.rs:445:5 | 445 | /// In other cases it's hard demon (thanks Ryder!). However, since we extract this information from | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 445 | /// In other cases it's hard demon (thanks Ryder!). However, since we extract this information from | ++
doc list item without indentation: src/model/level/mod.rs#L444
warning: doc list item without indentation --> src/model/level/mod.rs:444:5 | 444 | /// 6 = extreme demon. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 444 | /// 6 = extreme demon. | +
doc list item without indentation: src/model/level/mod.rs#L443
warning: doc list item without indentation --> src/model/level/mod.rs:443:5 | 443 | /// 5 = insane demon, | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 443 | /// 5 = insane demon, | +
doc list item without indentation: src/model/level/mod.rs#L442
warning: doc list item without indentation --> src/model/level/mod.rs:442:5 | 442 | /// 4 = medium demon, | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 442 | /// 4 = medium demon, | +
doc list item without indentation: src/model/level/mod.rs#L441
warning: doc list item without indentation --> src/model/level/mod.rs:441:5 | 441 | /// 3 = easy demon, | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 441 | /// 3 = easy demon, | +
doc list item without indentation: src/model/level/mod.rs#L439
warning: doc list item without indentation --> src/model/level/mod.rs:439:5 | 439 | /// [`LevelRating::Auto`] | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 439 | /// [`LevelRating::Auto`] | ++
doc list item without indentation: src/model/level/mod.rs#L438
warning: doc list item without indentation --> src/model/level/mod.rs:438:5 | 438 | /// [`Level::difficulty`] is equal to | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 438 | /// [`Level::difficulty`] is equal to | ++
doc list item without indentation: src/model/level/mod.rs#L437
warning: doc list item without indentation --> src/model/level/mod.rs:437:5 | 437 | /// whether the level is an auto level. This is equivalent to checking if | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 437 | /// whether the level is an auto level. This is equivalent to checking if | ++
doc list item without indentation: src/model/level/mod.rs#L435
warning: doc list item without indentation --> src/model/level/mod.rs:435:5 | 435 | /// [`Level::difficulty`] is the [`LevelRating::Demon`] variant. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 435 | /// [`Level::difficulty`] is the [`LevelRating::Demon`] variant. | ++
doc list item without indentation: src/model/level/mod.rs#L434
warning: doc list item without indentation --> src/model/level/mod.rs:434:5 | 434 | /// the level is a demon level. This is equivalent to checking if | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 434 | /// the level is a demon level. This is equivalent to checking if | ++
doc list item without indentation: src/model/level/mod.rs#L432
warning: doc list item without indentation --> src/model/level/mod.rs:432:5 | 432 | /// [`LevelRating::NotAvailable`] | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 432 | /// [`LevelRating::NotAvailable`] | ++
doc list item without indentation: src/model/level/mod.rs#L431
warning: doc list item without indentation --> src/model/level/mod.rs:431:5 | 431 | /// [`Level::difficulty`] is unequal to | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 431 | /// [`Level::difficulty`] is unequal to | ++
doc list item without indentation: src/model/level/mod.rs#L430
warning: doc list item without indentation --> src/model/level/mod.rs:430:5 | 430 | /// difficulty rating that isn't N/A. This is equivalent to checking if | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 430 | /// difficulty rating that isn't N/A. This is equivalent to checking if | ++
doc list item without indentation: src/model/level/mod.rs#L353
warning: doc list item without indentation --> src/model/level/mod.rs:353:9 | 353 | /// encoding described in [`Password`]'s documentation | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 353 | /// encoding described in [`Password`]'s documentation | ++
doc list item without indentation: src/model/level/mod.rs#L289
warning: doc list item without indentation --> src/model/level/mod.rs:289:9 | 289 | /// that changed at some point after 1.7 | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 289 | /// that changed at some point after 1.7 | ++
doc list item without indentation: src/model/level/mod.rs#L288
warning: doc list item without indentation --> src/model/level/mod.rs:288:9 | 288 | /// for the game to be able to correctly process passwords, and merely an implementation detail | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 288 | /// for the game to be able to correctly process passwords, and merely an implementation detail | ++
doc list item without indentation: src/model/level/mod.rs#L287
warning: doc list item without indentation --> src/model/level/mod.rs:287:9 | 287 | /// In-Game, passwords are sometimes left-padded with zeros. However, this is not a requirement | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation = note: `#[warn(clippy::doc_lazy_continuation)]` on by default help: indent this line | 287 | /// In-Game, passwords are sometimes left-padded with zeros. However, this is not a requirement | ++
the following explicit lifetimes could be elided: 'de: src/model/level/object/internal.rs#L91
warning: the following explicit lifetimes could be elided: 'de --> src/model/level/object/internal.rs:91:6 | 91 | impl<'de> GJFormat<'de> for LevelObject { | ^^^ ^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 91 - impl<'de> GJFormat<'de> for LevelObject { 91 + impl GJFormat<'_> for LevelObject { |
the following explicit lifetimes could be elided: 'de: src/model/level/metadata.rs#L37
warning: the following explicit lifetimes could be elided: 'de --> src/model/level/metadata.rs:37:6 | 37 | impl<'de> GJFormat<'de> for LevelMetadata { | ^^^ ^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 37 - impl<'de> GJFormat<'de> for LevelMetadata { 37 + impl GJFormat<'_> for LevelMetadata { |
the following explicit lifetimes could be elided: 'a: src/model/creator.rs#L40
warning: the following explicit lifetimes could be elided: 'a --> src/model/creator.rs:40:6 | 40 | impl<'a> Creator<'a> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `#[warn(clippy::needless_lifetimes)]` on by default help: elide the lifetimes | 40 - impl<'a> Creator<'a> { 40 + impl Creator<'_> { |
elided lifetime has a name: src/serde/mod.rs#L35
warning: elided lifetime has a name --> src/serde/mod.rs:35:64 | 31 | pub trait GJFormat<'de>: Dash<'de> { | --- lifetime `'de` declared here ... 35 | fn from_gj_str(input: &'de str) -> Result<Self, de::error::Error> { | ^^^^^ this elided lifetime gets resolved as `'de`
bound is defined in more than one place: src/serde/ser/request.rs#L421
warning: bound is defined in more than one place --> src/serde/ser/request.rs:421:26 | 421 | fn serialize_element<T: ?Sized>(&mut self, value: &T) -> Result<(), Self::Error> | ^ 422 | where 423 | T: Serialize, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
bound is defined in more than one place: src/serde/ser/request.rs#L403
warning: bound is defined in more than one place --> src/serde/ser/request.rs:403:20 | 403 | fn collect_str<T: ?Sized>(self, _value: &T) -> Result<Self::Ok, Self::Error> | ^ 404 | where 405 | T: Display, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
bound is defined in more than one place: src/serde/ser/request.rs#L336
warning: bound is defined in more than one place --> src/serde/ser/request.rs:336:34 | 336 | fn serialize_newtype_variant<T: ?Sized>( | ^ ... 340 | T: Serialize, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
bound is defined in more than one place: src/serde/ser/request.rs#L329
warning: bound is defined in more than one place --> src/serde/ser/request.rs:329:33 | 329 | fn serialize_newtype_struct<T: ?Sized>(self, _name: &'static str, _value: &T) -> Result<Self::Ok, Self::Error> | ^ 330 | where 331 | T: Serialize, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
bound is defined in more than one place: src/serde/ser/request.rs#L310
warning: bound is defined in more than one place --> src/serde/ser/request.rs:310:23 | 310 | fn serialize_some<T: ?Sized>(self, value: &T) -> Result<Self::Ok, Self::Error> | ^ 311 | where 312 | T: Serialize, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
bound is defined in more than one place: src/serde/ser/request.rs#L159
warning: bound is defined in more than one place --> src/serde/ser/request.rs:159:24 | 159 | fn serialize_field<T: ?Sized>(&mut self, key: &'static str, value: &T) -> Result<(), Self::Error> | ^ 160 | where 161 | T: Serialize, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
bound is defined in more than one place: src/serde/ser/request.rs#L147
warning: bound is defined in more than one place --> src/serde/ser/request.rs:147:20 | 147 | fn collect_str<T: ?Sized>(self, _value: &T) -> Result<Self::Ok, Self::Error> | ^ 148 | where 149 | T: Display, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
bound is defined in more than one place: src/serde/ser/request.rs#L106
warning: bound is defined in more than one place --> src/serde/ser/request.rs:106:34 | 106 | fn serialize_newtype_variant<T: ?Sized>( | ^ ... 110 | T: Serialize, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
bound is defined in more than one place: src/serde/ser/request.rs#L99
warning: bound is defined in more than one place --> src/serde/ser/request.rs:99:33 | 99 | fn serialize_newtype_struct<T: ?Sized>(self, _name: &'static str, _value: &T) -> Result<Self::Ok, Self::Error> | ^ 100 | where 101 | T: Serialize, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
bound is defined in more than one place: src/serde/ser/request.rs#L80
warning: bound is defined in more than one place --> src/serde/ser/request.rs:80:23 | 80 | fn serialize_some<T: ?Sized>(self, _value: &T) -> Result<Self::Ok, Self::Error> | ^ 81 | where 82 | T: Serialize, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
bound is defined in more than one place: src/serde/ser/indexed.rs#L243
warning: bound is defined in more than one place --> src/serde/ser/indexed.rs:243:24 | 243 | fn serialize_field<T: ?Sized>(&mut self, key: &'static str, value: &T) -> Result<(), Self::Error> | ^ 244 | where 245 | T: Serialize, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
bound is defined in more than one place: src/serde/ser/indexed.rs#L231
warning: bound is defined in more than one place --> src/serde/ser/indexed.rs:231:20 | 231 | fn collect_str<T: ?Sized>(self, _value: &T) -> Result<Self::Ok, Self::Error> | ^ 232 | where 233 | T: Display, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
bound is defined in more than one place: src/serde/ser/indexed.rs#L189
warning: bound is defined in more than one place --> src/serde/ser/indexed.rs:189:34 | 189 | fn serialize_newtype_variant<T: ?Sized>( | ^ ... 193 | T: Serialize, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
bound is defined in more than one place: src/serde/ser/indexed.rs#L182
warning: bound is defined in more than one place --> src/serde/ser/indexed.rs:182:33 | 182 | fn serialize_newtype_struct<T: ?Sized>(self, _name: &'static str, _value: &T) -> Result<Self::Ok, Self::Error> | ^ 183 | where 184 | T: Serialize, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
bound is defined in more than one place: src/serde/ser/indexed.rs#L163
warning: bound is defined in more than one place --> src/serde/ser/indexed.rs:163:23 | 163 | fn serialize_some<T: ?Sized>(self, value: &T) -> Result<Self::Ok, Self::Error> | ^ 164 | where 165 | T: Serialize, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations = note: `#[warn(clippy::multiple_bound_locations)]` on by default
elided lifetime has a name: src/request/mod.rs#L102
warning: elided lifetime has a name --> src/request/mod.rs:102:115 | 102 | pub const fn new(game_version: GameVersion, binary_version: GameVersion, secret: &'static str) -> BaseRequest<'_> { | ^^ this elided lifetime gets resolved as `'static` | = note: `#[warn(elided_named_lifetimes)]` on by default help: consider specifying it explicitly | 102 | pub const fn new(game_version: GameVersion, binary_version: GameVersion, secret: &'static str) -> BaseRequest<'static> { | ~~~~~~~
you are explicitly cloning with `.map()`: dash-rs-derive/src/utils.rs#L8
warning: you are explicitly cloning with `.map()` --> dash-rs-derive/src/utils.rs:8:26 | 8 | let first_lifetime = lifetime_iter.next().map(Clone::clone); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `lifetime_iter.next().cloned()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone = note: `#[warn(clippy::map_clone)]` on by default
coverage
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
coverage
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
coverage
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
coverage
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
coverage
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
coverage: src/request/mod.rs#L102
elided lifetime has a name
coverage: src/serde/mod.rs#L35
elided lifetime has a name
coverage
`dash-rs` (lib) generated 2 warnings (run `cargo fix --lib -p dash-rs` to apply 1 suggestion)