Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for other GD related servers (including GDPSes) #48

Closed
wants to merge 1 commit into from

Conversation

yuptune
Copy link

@yuptune yuptune commented Jan 10, 2025

this commit adds GDPS_URL to dash-rs, which makes it easier to manage a Pointercrate instance that is used for something other than the main Geometry Dash servers (e.g 1.9 GDPS). If there is anything wrong with this commit, comment on it. Thanks :P

  • LG125 & yuptune

this commit adds GDPS_URL to dash-rs, which makes it easier to manage a Pointercrate instance that is used for something other than the main Geometry Dash servers (e.g 1.9 GDPS). If there is anything wrong with this commit, comment on it. Thanks :P

- LG125 & yuptune
Copy link
Owner

@stadust stadust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can solve this problem using OnceCell:

  1. change the const to a static of type OnceCell<&'static str>
  2. Have the get_gd_url be a call to OnceCell::get_or_init, with the "or init" part setting it to the boomlings servers
  3. use the get_gd_url function in all the submodules of request.

Then if someone wants to use dash-rs with a gdps, they can simply do a OnceCell::set at the beginning of their fn main to update the URL to point to a GDPS.

@yuptune
Copy link
Author

yuptune commented Jan 11, 2025

Hello, thanks for writing. I have to add other commits to the pull request as well, since there were changes i missed that lg125 put onto the fork. I will do this when I get the changes put on this PR. Thanks ;-)

@yuptune
Copy link
Author

yuptune commented Jan 11, 2025

Move to the new PR.

@yuptune yuptune closed this Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants