Check for batch_fn before calling close #8786
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When performing GEPA optimization using a pipeline that involves an embedder, the following error tends to occur:
```
Exception ignored in: <function Unbatchify.__del__ at 0x1263e0180>
Traceback (most recent call last):
File "/Users/zachbam/.local/share/mise/installs/python/3.12.11/lib/python3.12/site-packages/dspy/utils/unbatchify.py", line 112, in __del__
self.close()
File "/Users/zachbam/.local/share/mise/installs/python/3.12.11/lib/python3.12/site-packages/dspy/utils/unbatchify.py", line 92, in close
if not self.stop_event.is_set():
^^^^^^^^^^^^^^^
AttributeError: 'Unbatchify' object has no attribute 'stop_event'
```
The issue seems to stem from instances where deletion is called, but the object is already gone. My suggested fix resolves this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing GEPA optimization using a pipeline that involves an embedder, the following error tends to occur:
The issue seems to stem from instances where deletion is called, but the object is already gone. My suggested fix resolves this issue.