Dispatch datastar-fetch events on the element iteself #1079
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before contributing, please read the contribution guidelines. Any change in behavior must be accompanied by appropriate justification, clearly describing the problem, solution, and alternatives considered.
Problem Statement
#1077
datastar-fetch events don't use the normal standard of being dispatched on the element that creates them and bubbling up the dom. This makes catching specific ones you want with a
data-on:datastar-fetchmore complicated.Proposed Solution
Dispatch the events on the element where the expression calling them is defined. Fall back to dispatching on the document if the originating element is no longer in the document.
Alternatives Considered
evt.detail.el == elin everydata-on:datastar-fetch(this doesn't work if you want to catch the event from a parent element though, with bubbling it would 'just work')