-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDK for python #250
SDK for python #250
Conversation
e915345
to
a9d1a13
Compare
698df02
to
d178d0b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions for the pyproject.toml
file.
Any update on this, @lllama? |
I think it's good to go from the Python side @bencroker. Does it need anything from the DataStar side? |
Not as far as I can tell. There appear to be a few comments above that you haven’t addressed. |
0a0e9a9
to
4474d37
Compare
Yeah @bencroker. Thanks to @dalito and @anastygnome for the help. |
@lllama can you move the examples into the |
83e0f2e
to
0c20fa8
Compare
Moved the examples @bencroker. Thanks again to @dalito for spotting the Markdown issues. |
@lllama please update to use the v1.0.0-beta.1 syntax. |
Python constants are created using the QuickTemplate build pipeline. The SSE generator is a class with `classmethod`s which perform the various SDK functions. The use of classmethods will allow users to extend the class if needed. (Thanks to Tom D. <[email protected]> for the suggestion for this, plus the use of `__slots__`.) Also provides helpers and examples for the following frameworks: * Sanic * FastAPI * Django * Quart pyproject updates as suggested by dalito
Done @bencroker ! |
Thanks! |
@lllama next up is to create the code samples for the guide. |
Adds an SSE event generator for Python. Given that python has many different frameworks and no standard request/response objects, this SDK provides a low-level class for using with whatever approach a framework has for SSE.