Bring typescript snippets into line with other examples #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The reason for deno.ts and node.ts in the src folder is that they're used to respond to the shell based test suite and I didnt want the examples to be burdened with that. |
Please remove it. The code snippet should be the equivalent of the other SDKs. Move any usage instructions into the readme file, please. |
|
Are we sure |
|
I’m the meantime I‘m more concerned with having all code snippets align than adding new code. Feel free to open an issue or PR if you think it would be worthwhile exploring. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I kept the readSignal usage example though.