Skip to content

Update js/py signature lib and tests #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NIC619 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update js/py signature lib and tests #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9df3c5d
Treat condition as hex str when converting to BN
NIC619 Oct 27, 2021
798fdf3
Update signatures in test data
NIC619 Oct 27, 2021
d87d098
Fix python signature test transfer signing
NIC619 Oct 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crypto/starkware/crypto/signature/signature.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ function getTransferMsgHash(
let instructionType = oneBn;
if (condition !== null) {
condition = condition.substring(2);
assertInRange(new BN(condition), zeroBn, prime, 'condition');
assertInRange(new BN(condition, 16), zeroBn, prime, 'condition');
instructionType = twoBn;
}
return hashMsg(
Expand Down
2 changes: 1 addition & 1 deletion crypto/starkware/crypto/signature/signature_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ def test_transfer_signing_example(data_file: dict):
"""
Tests signing transfer. Parameters are from signature_test_data.json.
"""
private_key = int(data_file['meta_data']['party_a_order']['private_key'], 16)
private_key = int(data_file['meta_data']['transfer_order']['private_key'], 16)
public_key = private_to_stark_key(private_key)
key = 'transfer_order'
data = read_transfer_data(data_file[key])
Expand Down
8 changes: 4 additions & 4 deletions crypto/starkware/crypto/signature/signature_test_data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@
"sender_vault_id": 34,
"token": "0x3003a65651d3b9fb2eff934a4416db301afd112a8492aaf8d7297fc87dcd9f4",
"signature": {
"r": "0x735fffa9bf371ca294c5f74c15b434684cfe7e9e0500e6a59589ef05c1fce13",
"s": "0x1ddc49993ad678e2b5b80fb0e22a077b136353514f60edc3c2fc77d59dbd93e"
"r": "0x4c21b3df630eab38d75b5538e8f635167f4f7107a885d7adf542a7525240323",
"s": "0x5eacfaa59ed1b63d75241a1dbd9256d2efbe97f9451f2cf2a2af0bad5b5ab69"
},
"public_key": "0x59a543d42bcc9475917247fa7f136298bb385a6388c3df7309955fcb39b8dd4"
},
Expand All @@ -58,8 +58,8 @@
"sender_vault_id": 34,
"token": "0x3003a65651d3b9fb2eff934a4416db301afd112a8492aaf8d7297fc87dcd9f4",
"signature": {
"r": "0x735fffa9bf371ca294c5f74c15b434684cfe7e9e0500e6a59589ef05c1fce13",
"s": "0x1ddc49993ad678e2b5b80fb0e22a077b136353514f60edc3c2fc77d59dbd93e"
"r": "0x5003de97b66391d8609493ec3f51d9a8ee73c0f3ac866b647a9a6915c615f34",
"s": "0x2c91324c2d5f3746c8be017eb2c7e082e2128cbcf85aa1254b7510a87664be8"
},
"public_key": "0x59a543d42bcc9475917247fa7f136298bb385a6388c3df7309955fcb39b8dd4",
"condition": "0x318ff6d26cf3175c77668cd6434ab34d31e59f806a6a7c06d08215bccb7eaf8"
Expand Down