Skip to content

[nfoSceneParser] new config options #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

deLbe321
Copy link
Contributor

Added possibility for nfoSceneParser plugin to configure:

  • custom name of the nfo file
  • name of the user rating field
  • user rating multiplier
  • source for tags

Additionally added:

  • missing studio information on scene update
  • "folder" as possible name for scene image

@deLbe321 deLbe321 changed the title nfoSceneParser plugin new config options [nfoSceneParser] new config options Jun 24, 2025
@DogmaDragon
Copy link
Contributor

Could you please bump the version in the .yml file?

@Gykes
Copy link
Contributor

Gykes commented Jun 24, 2025

From an initial review it looks good. I will test and review more thoroughly when I get home from work today.

@deLbe321
Copy link
Contributor Author

From an initial review it looks good. I will test and review more thoroughly when I get home from work today.

I will greatly appreciate that. Although I tried to not change the default behavior, the last thing I would like to do is to break something for existing users. Update process will overwrite existing config.py for users?

@Gykes
Copy link
Contributor

Gykes commented Jun 24, 2025

If they update fully, yes they will need to redo their config.

If it was me I would create a backup and copy over the settings or just copy over your changes to my local version but it's going to be up to the user. TBH I feel like this isn't used a lot so most people won't bother updating lol

@deLbe321
Copy link
Contributor Author

Ok so just in case I added some protection to make sure the new version works with old config file that doesn't have these new properties.

Copy link
Contributor

@Gykes Gykes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes as technically my request is not a requirement, just a small improvement but it can be merged as is and shouldn't have any issues.

Copy link
Contributor

@Gykes Gykes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@DogmaDragon DogmaDragon merged commit 88863bc into stashapp:main Jun 25, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants