Fix for issue #185 #220
Merged
Fix for issue #185 #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes #185 |
YeungOnion
force-pushed
the
fix-discretecdf-default
branch
2 times, most recently
from
877253e to
ecb9133
Compare
…r bisection additional tests
…erse_cdf seemed generic enough to put elsewhere
YeungOnion
force-pushed
the
fix-discretecdf-default
branch
from
ecb9133 to
830f04e
Compare
also changed trait bounds to be less stringent
YeungOnion
force-pushed
the
fix-discretecdf-default
branch
from
a2fed4f to
bc911eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: default inverse_cdf method incorrectly implements generic integer bisection
also adds additional tests