Add #![no_std] support
#314
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `std::fmt` -> `core::fmt` - `std::f64` -> `core::f64` - misc.
- Gate some API that needs `Vec` behind the "std" feature - Add no_std stub for `make_param_text`
`core::error` needs an MSRV of 1.81, which is a bit too new for this crate
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #314 +/- ##
==========================================
- Coverage 93.81% 93.81% -0.01%
==========================================
Files 53 53
Lines 11996 12005 +9
==========================================
+ Hits 11254 11262 +8
- Misses 742 743 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #165.
Standard library types that exist in libcore are usually just reexported through
std::, so changing from e.g.std::f64tocore::f64results in no change in behavior.There are a few things to note:
nalgebra-dependent features require std at the moment. I'm not sureOVector/OMatrixcan be used without std because ofDyn, but nalgebra does supportno_stdandSVector/SMatrixshould work without libstd. Out of scope here though.no_std. E.g. all functions that have aVecparameter/return type likeOrderStatistics::ranks.core::error::Errorexists, but was only recently stabilized in 1.81.0. I decided to not use this yet and instead not implement the Error trait inno_std.String, so I just dropped it. Dev machines should usually have it available anyways.