-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Levy distribution #317
base: master
Are you sure you want to change the base?
Conversation
Hmm, while our check for consistency being an integrator is likely susceptible to the usual nuance of general forward integrators. The error message, below, indicates that two steps into the integration it's already off by 20%. Since it checks at each step this is pretty significant.
I'm not certain this is the case, but the implementations appear correct to me as well. Options I expect could be
We may need to update the check for continuous distributions to be more robust integration or rely on other constraints. I can open this part as a different issue. |
Hi, I am also contributing a little bit to NumPyro, a Python-based PPL. Their test suites are big and quite good. Looking at them may help. |
That's a very cool project, along with JAX. I think I may have seen JAX before and forgot about it. I took a pass through by skimming, searching, and with an LLM. Couldn't find one in that test suite. I've also been thinking, perhaps this is a little unnecessary: testing values for the function will isolate precision effects to and precision checking (done by Perhaps if we had a default impl of PDF for a CDF then this may have been a stronger requirement. But instead, an alternative sanity check might be going the other way and verifying a finite difference in the derivative over some "well-chosen" interval. @Qazalbash would you be willing to write an internal function analogous to the integrator for this and use that test instead? You could use it standalone in the test and for later development we could see if it works replacing the integrator within |
I am in favor of checking whether the gradient of a CDF equals a PDF. Is there any good autograd we can use?
I will experiment with some, Just to let you know it will not be soon. |
This PR adds the implementation of Levy distribution. There is some numerical error in checking PDF integrate to be equal to cdf. I revisited the implementation several times and found no ambiguity. Therefore, I am pushing to seek some guidance.