cl+el poc[WiP] #2804
Draft
cl+el poc[WiP] #2804
+876
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tersec
reviewed
Oct 30, 2024
tersec
reviewed
Oct 30, 2024
added 27 commits
January 10, 2025 11:30
Makefile: Disabled libbacktrace: for some reason was given a strange error DW_FORM_addrx. Requires further investigation, given that it can be a macos issue, or related to the fact tathatth nimbus-eth2 is a submodule. moved getPid to thread worker it self. might required further investigation regarding thread pattern. small typos
There are currently 2 issues: - fetch genesis state on empty data folder: error msg "The downloaded genesis state cannot be verified (checksum mismatch)\" The error arises from here: fetchGenesisState->network_metadata_downloads.fetchGenesisBytes.L58 something to do with the readssz or withState, investigations point to the data downloaded or some config missing WA: comment lines 58-62, compile and run until the fetch genesis state is completed, then you can uncomment, it works from here - spam of error messages: \"metrics error:New label values must be added from same thread as the metric was created from\": This happens due to the fact that libp2p declares some gauges, and given that they are created inside a thread, metrics library starts to complain. (no WA/correction so far)"
This is acting as hot fix for now, given that some metrics are requirements. However we need to collect the ones we need / want and find a way to extract them from nimbus-eth2 (or make them reusable by both )
All possible constraints regarding eth2 are identified and tested for possible solutions.
added 9 commits
January 10, 2025 11:30
bumped nim-ssz-serialization to '3397088499cefc2e7aa5e73a56ad2d5b0f091735'
- cancelled metrics collection until metrics library thread issue is solved - add clean support for unified
pedromiguelmiranda
force-pushed
the
dev/pedro/uni
branch
from
d5b5513 to
25e162f
Compare
added 3 commits
January 17, 2025 15:55
- updated Makefile - Updated README - refactored data types
bump nim-libp2p to fd26f93b80cfeecd4e6f9c84eb7a15a3be26c1ee bump nim-kzg844 to 33d2e9a5d4df1bbf4aca7cf00457bf15b1d657a6
tersec
reviewed
May 1, 2025
| "$@" | ||
| # --el=http://127.0.0.1:8551 \ | ||
| # --jwt-secret="/tmp/jwtsecret" \ | ||
| # --web3-url=http://127.0.0.1:8551 |
tersec
reviewed
May 1, 2025
| @@ -241,3 +241,23 @@ | |||
| path = vendor/nim-minilru | |||
| url = https://github.com/status-im/nim-minilru.git | |||
| branch = master | |||
| [submodule "vendor/mainnet"] | |||
tersec
reviewed
May 1, 2025
| discard defaultChroniclesStream.output.open(logFile, fmAppend) | ||
| proc run*(nimbus: NimbusNode, conf: NimbusConf) = | ||
| # ## logging | ||
| # setLogLevel(conf.logLevel) |
There was a problem hiding this comment.
don't randomly remove working EL code
tersec
reviewed
May 1, 2025
| # let fileName = conf.trustedSetupFile.get() | ||
| # let res = loadTrustedSetup(fileName, 0) | ||
| # if res.isErr: | ||
| # fatal "Cannot load Kzg trusted setup from file", msg=res.error |
tersec
reviewed
May 1, 2025
| # imports of that file. | ||
|
|
||
| declareGauge versionGauge, | ||
| "Nimbus version info (as metric labels)", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress for a cl+el single application.
Some notes:
current state:
beacon node metrics strategy ? issue with threads.
fetchgenesis mismatch error:
comments with:# NOTE, #TODO,are related to improvements or refactorings that need to be donecomments with:
# adapted from nimbus-eth2, things that were required to be overridden or not used (or we think that is not used)Probably the best course of action will be to create issues regarding it.
current state: able to synch (or it appears so) with two minor issues (check latest commit message)