Remove account leaf cache #3275
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnetheduck
force-pushed
the
no-acc-leaf-cache
branch
from
6939b1c to
f63d151
Compare
arnetheduck
force-pushed
the
static-vid
branch
2 times, most recently
from
49ffbd8 to
3da3aca
Compare
arnetheduck
force-pushed
the
no-acc-leaf-cache
branch
from
f63d151 to
d5909c0
Compare
|
this one is not a db change, once the underlying static-vid branch is merged |
arnetheduck
force-pushed
the
no-acc-leaf-cache
branch
from
307884c to
476dd58
Compare
With static vid lookup we can find cached accounts in `O(1)` in the regular caches - no need to waste time and effort on maintaining a separate path-based cache for it. Without the account leaf cache, the number of queries for non-existing vids spikes because of all the path-based guesses, which we compensate with a simpler "empty" cache in the database layer. We put the memory savings towards the branch/vtx caches instead.
arnetheduck
force-pushed
the
no-acc-leaf-cache
branch
from
476dd58 to
ca8bd29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With static vid lookup we can find cached accounts in
O(1)in the regular caches - no need to waste time and effort on maintaining a separate path-based cache for it.5% speed bump from just the removal - more to be had by reallocating the memory to other causes.