proxy: add blocks support #3338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

chirag-parmar wants to merge 9 commits into master from vp-blocks

+4,269 −80

Contributor

chirag-parmar commented May 27, 2025 •

edited

Loading

This PR adds support for block based RPC endpoints by adding the following:

helper functions for downloading and verifying blocks and headers via JSON-RPC API under rpc/blocks.nim
helper functions to verify transaction trie roots and withdrawals root under rpc/transactions.nim
adds block based JSON RPC method handlers (check this)

chirag-parmar changed the title ~~add blocks support~~ proxy: add blocks support

chirag-parmar marked this pull request as ready for review

May 27, 2025 21:54

chirag-parmar requested review from advaita-saha and bhartnett

May 27, 2025 21:54

tersec reviewed

View reviewed changes

nimbus_verified_proxy/header_store.nim Outdated Show resolved Hide resolved

tersec reviewed

View reviewed changes

nimbus_verified_proxy/header_store.nim Outdated Show resolved Hide resolved

tersec reviewed

View reviewed changes

nimbus_verified_proxy/rpc/transactions.nim Outdated Show resolved Hide resolved

tersec reviewed

View reviewed changes

nimbus_verified_proxy/rpc/transactions.nim Outdated Show resolved Hide resolved

tersec reviewed

View reviewed changes

nimbus_verified_proxy/rpc/transactions.nim Outdated Show resolved Hide resolved

tersec reviewed

View reviewed changes

nimbus_verified_proxy/rpc/transactions.nim Outdated Show resolved Hide resolved

tersec reviewed

View reviewed changes

nimbus_verified_proxy/rpc/blocks.nim Outdated Show resolved Hide resolved

bhartnett reviewed

View reviewed changes

nimbus_verified_proxy/rpc/blocks.nim Outdated Show resolved Hide resolved

bhartnett reviewed

View reviewed changes

nimbus_verified_proxy/rpc/blocks.nim Outdated Show resolved Hide resolved

bhartnett reviewed

View reviewed changes

nimbus_verified_proxy/rpc/blocks.nim Outdated Show resolved Hide resolved

bhartnett reviewed

View reviewed changes

nimbus_verified_proxy/rpc/blocks.nim Outdated Show resolved Hide resolved

bhartnett reviewed

View reviewed changes

nimbus_verified_proxy/rpc/blocks.nim Outdated Show resolved Hide resolved

bhartnett reviewed

View reviewed changes

nimbus_verified_proxy/rpc/blocks.nim Outdated Show resolved Hide resolved

bhartnett reviewed

View reviewed changes

nimbus_verified_proxy/rpc/blocks.nim Outdated Show resolved Hide resolved

bhartnett reviewed

View reviewed changes

nimbus_verified_proxy/rpc/blocks.nim Outdated Show resolved Hide resolved

bhartnett reviewed

View reviewed changes

nimbus_verified_proxy/rpc/blocks.nim Outdated Show resolved Hide resolved

bhartnett reviewed

View reviewed changes

nimbus_verified_proxy/rpc/blocks.nim Outdated Show resolved Hide resolved

bhartnett reviewed

View reviewed changes

nimbus_verified_proxy/rpc/blocks.nim Outdated Show resolved Hide resolved

bhartnett reviewed

View reviewed changes

nimbus_verified_proxy/rpc/blocks.nim Outdated Show resolved Hide resolved

bhartnett reviewed

View reviewed changes

nimbus_verified_proxy/rpc/transactions.nim Outdated Show resolved Hide resolved

bhartnett reviewed

View reviewed changes

nimbus_verified_proxy/rpc/transactions.nim Outdated Show resolved Hide resolved

chirag-parmar force-pushed the vp-blocks branch from 51a508d to dea9450 Compare

May 29, 2025 06:51

Contributor Author

chirag-parmar commented May 29, 2025

@tersec and @bhartnett all reviews have been addressed

bhartnett reviewed

View reviewed changes

nimbus_verified_proxy/rpc/blocks.nim Outdated Show resolved Hide resolved

Contributor

bhartnett commented May 29, 2025

@chirag-parmar It would be good to get some basic unit tests on the code in the blocks.nim and transactions.nim files. I would aim for at least one test covering the success scenario of each of the public exported functions.

bhartnett reviewed

View reviewed changes

nimbus_verified_proxy/rpc/transactions.nim Outdated Show resolved Hide resolved

chirag-parmar force-pushed the vp-blocks branch from 223dab8 to 810649a Compare

May 31, 2025 04:30

kdeme reviewed

View reviewed changes

nimbus_verified_proxy/rpc/blocks.nim Outdated Show resolved Hide resolved

nimbus_verified_proxy/rpc/rpc_eth_api.nim Show resolved Hide resolved

nimbus_verified_proxy/rpc/rpc_eth_api.nim Show resolved Hide resolved

nimbus_verified_proxy/rpc/rpc_eth_api.nim Show resolved Hide resolved

nimbus_verified_proxy/rpc/blocks.nim Outdated Show resolved Hide resolved

nimbus_verified_proxy/rpc/blocks.nim Outdated Show resolved Hide resolved

nimbus_verified_proxy/rpc/blocks.nim Outdated Show resolved Hide resolved

nimbus_verified_proxy/rpc/blocks.nim Outdated Show resolved Hide resolved

nimbus_verified_proxy/rpc/blocks.nim Show resolved Hide resolved

chirag-parmar force-pushed the vp-blocks branch from 3badaf9 to 247a98c Compare

June 10, 2025 16:09

chirag-parmar force-pushed the vp-blocks branch from 247a98c to 9e0ce1d Compare

June 24, 2025 12:49

Contributor Author

chirag-parmar commented Jun 24, 2025

@bhartnett added some basic tests

chirag-parmar added 9 commits

June 24, 2025 18:26


          add blocks support

e807f70


          add rpc handlers

ff24cea


          reviews

c6170e5


          format


          catch only error exceptions

fdac841


          remove unused imports

7dd9ec4


          review

888695f


          add basics tests

318dfdb

fix

52b121a

chirag-parmar force-pushed the vp-blocks branch from 9e0ce1d to 52b121a Compare

June 24, 2025 12:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet