aristo: fold Adm column family into Vtx #3383
Open
+100
−90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each column family in rocksdb requires its own set of SST files that must be kept open, cached etc. Further, wal files are [deleted]() only once all column families referencing them have been flushed meaning that low-volume families like Adm can keep them around far longer than makes sense. Adm contains only two useful metadata entries and therefore it doesn't really make sense to allocate an entire CF for it. Consolidating Adm into Vtx also makes it easier to reason about the internal consistency of the Vtx table - even though rocksdb ensures atomic cross-cf writes via the wal, it requires using a special batch write API that introduces its own overhead. With this change, don't need to rely on this particular rocksdb feature to maintain atomic consistency within Vtx. Databases using the old schema are supported but rollback is not (ie the old metadata format/CF is read but not written)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each column family in rocksdb requires its own set of SST files that must be kept open, cached etc. Further, wal files are deleted only once all column families referencing them have been flushed meaning that low-volume families like Adm can keep them around far longer than makes sense.
Adm contains only two useful metadata entries and therefore it doesn't really make sense to allocate an entire CF for it.
Consolidating Adm into Vtx also makes it easier to reason about the internal consistency of the Vtx table - even though rocksdb ensures atomic cross-cf writes via the wal, it requires using a special batch write API that introduces its own overhead. With this change, don't need to rely on this particular rocksdb feature to maintain atomic consistency within Vtx.
Databases using the old schema are supported but rollback is not (ie the old metadata format/CF is read but not written)