add eip-7883 changes #3399
Draft
add eip-7883 changes #3399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 13, 2025
Closed
Closed
jangko
reviewed
Jun 14, 2025
advaita-saha
commented
Jun 16, 2025
tersec
reviewed
Jun 16, 2025
| if maxLen > 32.u256: | ||
| result = maxLen + 7 | ||
| result = result div 8 | ||
| result = result * result |
There was a problem hiding this comment.
Is there a reason for this result = result ... accumulator style? If it were managing to be truly in-place with these large operands, that might be interesting, but it's using formally full calculation then assignment style.
There was a problem hiding this comment.
iirc stint doesn't have *= operator.
There was a problem hiding this comment.
Sure, but then why not use a more usual expression style rather than accumulate through result? It's not really saving any CPU or memory that I can tell.
There was a problem hiding this comment.
no particular reason, feel free to rewrite it using expression style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ethereum/EIPs@5cdd751#diff-deb61419789ec2f1fd580a01375e9c1ab84989138683faf6ab2306283219bcaeL32-R32