portal: pass list item instead of list #3414
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chirag-parmar
changed the title
bhartnett
reviewed
Jun 19, 2025
| @@ -130,7 +130,7 @@ proc fromJson*(n: JsonNode, name: string, x: var seq[Authorization]) = | |||
| let node = n[name] | |||
| for v in node: | |||
| x = newSeqOfCap[Authorization](node.len) | |||
| x.add parseAuth(node) | |||
| x.add parseAuth(v) | |||
There was a problem hiding this comment.
This code still doesn't look right. Why does the seq get recreated on each iteration of the loop?
x = newSeqOfCap[Authorization](node.len)
I didn't write this code so perhaps @kdeme has a better idea?
There was a problem hiding this comment.
I don't know either, I did not write it. It got copied over from premix before that got removed
bhartnett
approved these changes
Jun 21, 2025
|
Everything about this seems weird, but, sure. It looks like an improvement? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.