networking: remove DiscoveryV4 support, use DiscoveryV5 only - #4476
Draft
kdeme wants to merge 1 commit into
Draft
Conversation
kdeme
marked this pull request as draft
July 13, 2026 13:18
Contributor
Author
|
In draft until it's actually OK to remove (Which would mean a nethermind release with default discv5 enabled out for certain amount of time). This is the basic removal of discv4.. There is however still quite some boiler plate (the extra discovery file) that can be removed if some things get restructured. |
kdeme
force-pushed
the
remove-discv4
branch
2 times, most recently
from
July 13, 2026 19:46
ea93d32 to
87c5a74
Compare
Removes discv4 protocol, kademlia, shared port hack and related tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes discv4 protocol, kademlia, shared port hack and related tests.