first draft of getBlobs
#6913
Draft
first draft of getBlobs
#6913
+123
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
for devnet testing locally, use |
tersec
reviewed
Feb 12, 2025
| @@ -57,6 +57,7 @@ type | |||
| GetPayloadV3Response | | |||
| GetPayloadV4Response | |||
|
|
|||
|
|
|||
tersec
reviewed
Feb 12, 2025
| when consensusFork >= ConsensusFork.Electra: | ||
| # Pull blobs and proofs from the EL blob pool | ||
| let blobsFromElOpt = await node.elManager.sendGetBlobs(forkyBlck) | ||
| debugEcho "pulled blobs from el" |
There was a problem hiding this comment.
Obligatory comment about debugEcho (but yeah, it's a draft PR and useful for now)
There was a problem hiding this comment.
just for now, until i see things are ok in the local devnet
tersec
reviewed
Feb 12, 2025
| return ok(requests[bestResponse.get()].value().blobsAndProofs) | ||
|
|
||
| else: | ||
| # should not reach this case |
There was a problem hiding this comment.
How "should" is this (i.e. if it's a logic bug, or a potentially buggy EL, or etc)?
tersec
reviewed
Feb 12, 2025
| return err() | ||
| let | ||
| timeout = GETBLOBS_TIMEOUT | ||
| deadline = sleepAsync(timeout) |
There was a problem hiding this comment.
Why not directly use GETBLOBS_TIMEOUT?
There was a problem hiding this comment.
i was considering to add some extra processing latency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ethereum/execution-apis#559
if EL supports
engine_getBlobsV1else
Note:
getBlobsinnimbus-eth2here is made to backward compatible from Electra and NOT Deneb as per specCI failing: because of some nim-web3 upstream incompatibilities