fix(e2e_appium): log xfail tests as XFAIL in console, not FAILED#21071
Open
glitchminer wants to merge 1 commit into
Open
fix(e2e_appium): log xfail tests as XFAIL in console, not FAILED#21071glitchminer wants to merge 1 commit into
glitchminer wants to merge 1 commit into
Conversation
pytest_runtest_teardown derived success from rep_call.passed, which is False for an xfailed test (it reports as skipped-with-wasxfail) — so every xfail logged "Test FAILED" in test_run_*.log even though the run is green. Detect xfail and emit a distinct XFAIL line so nightly logs don't mislabel expected failures.
Member
Jenkins Builds
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pytest_runtest_teardown derived test success from rep_call.passed, which is False for an xfailed test (it reports as skipped-with-wasxfail). As a result every xfail was logged as "Test FAILED" in the run console log even though the run was green. This detects xfail and logs a distinct "XFAIL" line so logs don't mislabel expected failures.