-
Notifications
You must be signed in to change notification settings - Fork 81
fix_: cache read-only communities to reduce memory pressure #17781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@status-im/desktop-qa would you mind testing the critical communities flow when you get a chance? Your help would be greatly appreciated! |
Jenkins BuildsClick to see older builds (7)
|
Hi @osmaczko I'm seeing that this issue #17774 is reproducible on this PR but I think it is because the build of this pR may not include the mentioned fix. In order to better test the critical flows, including the messages, is it possible to update the build of this PR to include the fix of 17774 ? Thanks! |
4735c3d
to
a6f750a
Compare
@virginiabalducci thanks for looking into this. Rebased, build in progress. |
Testing is in progress Issues found so far: Channel permissions Steps:
Actual result: nothing happens, the permission is not saved. Errors show on the app console Screen.Recording.2025-04-15.at.12.30.11.PM.movScreen.Recording.2025-04-15.at.12.33.22.PM.mov@osmaczko I've tested the channel permissions on today's master, and they work well. Could you check the permissions on the build of this PR? Thanks! |
a6f750a
to
8cac370
Compare
@virginiabalducci I've rebased the PR and can't reproduce the issue you've reported. Can you please take another look? communities-with-cache-2025-05-13_17.25.23.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good now, thanks!
Thanks 🙏 |
Tests: status-im/status-go#6519