feat(@desktop/browser): Improve incognito mode color scheme #19396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Jenkins BuildsClick to see older builds (75)
|
Khushboo-dev-cpp
force-pushed
the
feat/IncognitoMode
branch
2 times, most recently
from
8d77b80 to
b0ca456
Compare
Khushboo-dev-cpp
requested review from
a team,
alexjba,
caybro,
micieslak and
noeliaSD
as code owners
Khushboo-dev-cpp
requested review from
saledjenic
and removed request for
a team
Khushboo-dev-cpp
force-pushed
the
feat/IncognitoMode
branch
from
b0ca456 to
948696f
Compare
Member
|
I wonder how the colors look like when in full Privacy mode + this Web incognito mode ;) |
Khushboo-dev-cpp
force-pushed
the
feat/IncognitoMode
branch
from
948696f to
59afc78
Compare
alaibe
approved these changes
Nov 27, 2025
alexjba
approved these changes
Nov 28, 2025
Khushboo-dev-cpp
force-pushed
the
feat/IncognitoMode
branch
from
59afc78 to
f2b74ff
Compare
Khushboo-dev-cpp
force-pushed
the
feat/IncognitoMode
branch
from
f2b74ff to
9404f5c
Compare
Khushboo-dev-cpp
force-pushed
the
feat/IncognitoMode
branch
from
9404f5c to
5bd0686
Compare
Khushboo-dev-cpp
force-pushed
the
feat/IncognitoMode
branch
from
5bd0686 to
4b1a11f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #19256
What does the PR do
implements new incognito mode colors defined in design https://www.figma.com/design/pJgiysu3rw8XvL4wS2Us7W/DS?node-id=3193-73460&m=dev
Affected areas
Browser Header
Architecture compliance
My PR is consistent with this document: QML Architecture Guidelines
Screencapture of the functionality
Impact on end user
How to test
Risk