ci_: upgrade go to 1.22 #6258
Open
ci_: upgrade go to 1.22 #6258
+122
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (149)
|
siddarthkay
force-pushed
the
bump-go-to-1-23
branch
3 times, most recently
from
f95fafe to
c74ebd3
Compare
|
My initial assumptions were that this failure happens due to a symlink issue in xcode wrapper nix derivation : Needs more investigation. This issue surfaces in |
siddarthkay
force-pushed
the
bump-go-to-1-23
branch
from
c74ebd3 to
2d2d927
Compare
siddarthkay
force-pushed
the
bump-go-to-1-23
branch
from
2d2d927 to
dd262fa
Compare
siddarthkay
force-pushed
the
bump-go-to-1-23
branch
3 times, most recently
from
b273909 to
58e0a24
Compare
igor-sirotin
approved these changes
Jan 16, 2025
I first tried with 1.23, there were many issues, I tried to outline the recommended steps here #6254 (comment) |
siddarthkay
force-pushed
the
bump-go-to-1-23
branch
from
58e0a24 to
7372d20
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6258 +/- ##
===========================================
- Coverage 60.30% 59.61% -0.69%
===========================================
Files 845 864 +19
Lines 111258 112668 +1410
===========================================
+ Hits 67095 67168 +73
- Misses 36342 37715 +1373
+ Partials 7821 7785 -36
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This was referenced Jan 16, 2025
jakubgs
approved these changes
Jan 16, 2025
yakimant
approved these changes
Jan 21, 2025
| }) | ||
| ]; | ||
| })); | ||
| gomobile = callPackage ./pkgs/gomobile { }; |
There was a problem hiding this comment.
Add a comment, why it is needed.
There was a problem hiding this comment.
Also, is it just a copy from certain commit (add which one) or some lines were edited (add comments, which ones and why)?
There was a problem hiding this comment.
Thanks! I will update comments.
Here i was updating to a newer version of gomobile and using latest derivation from master of nixpkgs.
siddarthkay
force-pushed
the
bump-go-to-1-23
branch
2 times, most recently
from
87151d7 to
71a04fe
Compare
siddarthkay
force-pushed
the
bump-go-to-1-23
branch
2 times, most recently
from
82a47d3 to
8cab389
Compare
jakubgs
approved these changes
Feb 4, 2025
| @@ -8,7 +8,7 @@ let | |||
|
|
|||
| /* Lock requires Xcode verison. */ | |||
| xcodeWrapper = callPackage ./pkgs/xcodeenv/compose-xcodewrapper.nix { } { | |||
| versions = ["14.3" "15.1" "15.2" "15.3" "15.4"]; | |||
| versions = [ ]; | |||
There was a problem hiding this comment.
I have kept it empty to accept whatever version of Xcode exists on CI hosts.
Waiting to complete the Xcode migration of CI hosts and then I will pin 16.x here
There was a problem hiding this comment.
Well, if there's no known versions of Xcode that break status-go builds that might be fine.
siddarthkay
force-pushed
the
bump-go-to-1-23
branch
from
8cab389 to
808ddfd
Compare
siddarthkay
added a commit
to status-im/status-mobile
that referenced
this pull request
Feb 5, 2025
- This PR upgrades `go` to `1.22` - Brings in `gomobile` latest derivation at master of `nixpkgs` : NixOS/nixpkgs@f5abef9 - points to status-go changes where `go` is also upgraded to `1.22` -> status-im/status-go#6258
siddarthkay
added a commit
to status-im/status-desktop
that referenced
this pull request
Feb 5, 2025
This commit: - updates status-go to point to status-im/status-go#6258 - updates nix derivation to switch to go 1.22 - swaps `sc3md` for `sc5md` - updates docker image used by jenkins for linux jobs to image built with go 1.22. - updates, linux, windows and MacOS build scripts to use go 1.22
siddarthkay
force-pushed
the
bump-go-to-1-23
branch
from
5972f31 to
562eace
Compare
siddarthkay
added a commit
to status-im/status-desktop
that referenced
this pull request
Feb 5, 2025
This commit: - updates status-go to point to status-im/status-go#6258 - updates nix derivation to switch to go 1.22 - swaps `sc3md` for `sc5md` - updates docker image used by jenkins for linux jobs to image built with go 1.22. - updates, linux, windows and MacOS build scripts to use go 1.22
siddarthkay
added a commit
to status-im/status-desktop
that referenced
this pull request
Feb 6, 2025
This commit: - updates status-go to point to status-im/status-go#6258 - updates nix derivation to switch to go 1.22 - swaps `sc3md` for `sc5md` - updates docker image used by jenkins for linux jobs to image built with go 1.22. - updates, linux, windows and MacOS build scripts to use go 1.22
siddarthkay
added a commit
to status-im/status-desktop
that referenced
this pull request
Feb 12, 2025
This commit: - updates status-go to point to status-im/status-go#6258 - updates nix derivation to switch to go 1.22 - swaps `sc3md` for `sc5md` - updates docker image used by jenkins for linux jobs to image built with go 1.22. - updates, linux, windows and MacOS build scripts to use go 1.22
siddarthkay
force-pushed
the
bump-go-to-1-23
branch
from
562eace to
89e0d84
Compare
|
We require commits to follow the Conventional Commits, but with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issue: #6254
Summary
goto1.22xcodewrapperto latest version fromnixpkgsgomobilederivation with newer version.1.59.1forgoversion1.22support https://github.com/golangci/golangci-lint/releases/tag/v1.59.1gosecPending
Related
GO111MODULE=offworkaround golang/go#67927