Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore_: LoginAccount simplifications #6338

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Conversation

igor-sirotin
Copy link
Collaborator

@igor-sirotin igor-sirotin commented Feb 11, 2025

Required for status-im/status-desktop#17273

Description

In LoginAccount:

  1. Ensure provided Mnemonic key uid matches the given KeyUID
  2. Automatically get kdfIterations from multiaccounts database.kdfIteractions argument is deprecated with a fallback.

Both changes are needed for Start using this account without account login flow.

@status-im-auto
Copy link
Member

status-im-auto commented Feb 11, 2025

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ f41440e #1 2025-02-11 21:23:47 ~3 min macos 📦zip
✔️ f41440e #1 2025-02-11 21:24:58 ~5 min macos 📦zip
✔️ f41440e #1 2025-02-11 21:25:09 ~5 min linux 📦zip
✔️ f41440e #1 2025-02-11 21:25:32 ~5 min windows 📦zip
✔️ f41440e #1 2025-02-11 21:25:54 ~6 min ios 📦zip
✔️ f41440e #1 2025-02-11 21:28:13 ~8 min tests-rpc 📄log
✔️ f41440e #1 2025-02-11 21:50:39 ~30 min tests 📄log
✔️ f41440e #2 2025-02-12 12:42:28 ~5 min android 📦aar

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 60.35%. Comparing base (735b574) to head (f41440e).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
api/geth_backend.go 33.33% 3 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (33.33%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6338      +/-   ##
===========================================
- Coverage    60.41%   60.35%   -0.06%     
===========================================
  Files          845      845              
  Lines       111357   111362       +5     
===========================================
- Hits         67274    67214      -60     
- Misses       36279    36329      +50     
- Partials      7804     7819      +15     
Flag Coverage Δ
functional 0.45% <0.00%> (-0.01%) ⬇️
unit 60.37% <33.33%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
protocol/requests/login.go 57.14% <ø> (ø)
api/geth_backend.go 53.96% <33.33%> (-0.11%) ⬇️

... and 25 files with indirect coverage changes

@igor-sirotin igor-sirotin merged commit 3e43522 into develop Feb 12, 2025
19 of 20 checks passed
@igor-sirotin igor-sirotin deleted the chore/simplify-loginaccount branch February 12, 2025 14:21
friofry added a commit that referenced this pull request Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants