feat(wallet)_: Add BNB Smart Chain #6466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (201)
|
smohamedjavid
force-pushed
the
feat/bnb-smart-chain
branch
from
1cdf97f to
ff97a8b
Compare
dlipicar
reviewed
Apr 1, 2025
|
We can get away with treating BEP-20 tokens as ERC-20 tokens since they're basically identical, but for correctness we'll probably want to make this difference explicit at some point. |
dlipicar
reviewed
Apr 1, 2025
2 tasks
dlipicar
reviewed
Apr 4, 2025
services/wallet/router/pathprocessor/processor_swap_paraswap.go
Outdated
Show resolved
Hide resolved
dlipicar
reviewed
Apr 4, 2025
services/wallet/router/pathprocessor/processor_swap_paraswap.go
Outdated
Show resolved
Hide resolved
|
@smohamedjavid I tried swapping DAI to BNB, it did the approval but then I didn't get the actual Swap. Could you try this in mobile? |
dlipicar
force-pushed
the
feat/bnb-smart-chain
branch
from
ff97a8b to
cd0d253
Compare
smohamedjavid
force-pushed
the
feat/bnb-smart-chain
branch
2 times, most recently
from
ee6515a to
87ad407
Compare
I swapped 2 BUSD for 1.998 DAI: Approval TX | Swap TX Then 1.99 DAI to 0.00368 BNB: Approval TX | Swap TX Everything worked as expected and performed on BSC Mainnet. Let me know if I need to try any different/higher amount values. |
|
@smohamedjavid alright, swap fixed on Desktop, it was a mistake on my side! |
smohamedjavid
force-pushed
the
feat/bnb-smart-chain
branch
3 times, most recently
from
4b78e43 to
3ce5431
Compare
|
@smohamedjavid I don't see that you've updated this function status-go/services/wallet/token/token.go Line 639 in 4f33989 Also I don't see a function similar to status-go/services/wallet/token/token.go Line 412 in 4f33989 Basically, we should add it to all places where we use |
|
I see how the native BNB is added, forget the previous comment. |
smohamedjavid
force-pushed
the
feat/bnb-smart-chain
branch
from
3ce5431 to
e89a270
Compare
saledjenic
force-pushed
the
feat/bnb-smart-chain
branch
from
e89a270 to
333643b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6466 +/- ##
===========================================
+ Coverage 60.40% 60.51% +0.11%
===========================================
Files 832 833 +1
Lines 103779 104359 +580
===========================================
+ Hits 62688 63155 +467
- Misses 33546 33665 +119
+ Partials 7545 7539 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
saledjenic
force-pushed
the
feat/bnb-smart-chain
branch
from
12e11a0 to
4be80d4
Compare
Signed-off-by: Mohamed Javid <[email protected]>
Signed-off-by: Mohamed Javid <[email protected]>
Signed-off-by: Mohamed Javid <[email protected]>
Signed-off-by: Mohamed Javid <[email protected]>
Signed-off-by: Mohamed Javid <[email protected]>
…ction for the path type
What's changed: - analyzer updated to identify symbol and decimals collisons - before resolving the collision, the duplicate symbols are resolved within each list by skipping other entries - if there is a symbol collision the uniswap tokens list is the source of truth - if there is a decimal collision (the same symbol, but different decimals used) the symbol is updated (e.g. USDC(6), USDC(18))
Since the decimal collision is solved by adding the decimals as postfix to the symbol name an extra mapping is necessary to map those symbols to/from symbols recognized by the price providers.
…mark Changes include: - Replaced postfix for decimals collision, symbols include l1 chain based mark instead of decimals. - Token filtering logic added to ensure that only chains the app knows about are present (otherwise, it cannot guarantee uniqueness without decimals included). - Replaced hardcoded chain ID with a constant for `TestnetChainID` and added to `AllChainIDs`, which fixed tests balancechecker. - Updated no-balance tests for the router that were failing due to the new BSC chain added.
…P Contracts Signed-off-by: Mohamed Javid <[email protected]>
Signed-off-by: Mohamed Javid <[email protected]>
saledjenic
force-pushed
the
feat/bnb-smart-chain
branch
from
de9756c to
c5a5910
Compare
…e provided path tx identity
Signed-off-by: Mohamed Javid <[email protected]>
Signed-off-by: Mohamed Javid <[email protected]>
Signed-off-by: Mohamed Javid <[email protected]>
Signed-off-by: Mohamed Javid <[email protected]>
saledjenic
force-pushed
the
feat/bnb-smart-chain
branch
from
9f98111 to
bbe8e10
Compare
smohamedjavid
requested review from
saledjenic,
dlipicar,
alaibe and
shivekkhurana
|
Need some approval to merge 🙏 |
saledjenic
approved these changes
May 13, 2025
alaibe
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needed for status-im/status-mobile#22309
Summary
This PR adds BNB Smart Chain support
Notes
The bridge is supported as Hop doesn't support BSC