feat(development)_: add nix flake and expose devshells and packages through it #6529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (309)
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6529 +/- ##
===========================================
+ Coverage 60.38% 60.51% +0.13%
===========================================
Files 849 849
Lines 105116 105116
===========================================
+ Hits 63470 63607 +137
+ Misses 34025 33946 -79
+ Partials 7621 7563 -58
Flags with carried forward coverage won't be shown. Click here to find out more. |
jakubgs
approved these changes
Apr 18, 2025
|
@jakubgs I added more changes to this PR but I think you will want to look at them since this was 'just to make it work' effort. I didn't want to touch |
markoburcul
force-pushed
the
add-flake
branch
4 times, most recently
from
00ea272 to
47f2f91
Compare
jakubgs
requested changes
May 7, 2025
markoburcul
changed the title
markoburcul
force-pushed
the
add-flake
branch
7 times, most recently
from
665f614 to
0bba7d6
Compare
markoburcul
changed the title
markoburcul
changed the title
markoburcul
changed the title
markoburcul
force-pushed
the
add-flake
branch
2 times, most recently
from
2426d17 to
5ccf78b
Compare
markoburcul
force-pushed
the
add-flake
branch
2 times, most recently
from
1b83357 to
c3991b9
Compare
markoburcul
force-pushed
the
add-flake
branch
5 times, most recently
from
0bb8f14 to
076190e
Compare
jakubgs
approved these changes
May 16, 2025
markoburcul
force-pushed
the
add-flake
branch
6 times, most recently
from
cb49b30 to
e94ba81
Compare
jakubgs
approved these changes
May 22, 2025
markoburcul
force-pushed
the
add-flake
branch
4 times, most recently
from
e8d5103 to
e806e32
Compare
✔️ status-go/prs/tests/PR-6529#33 🔹 ~34 min 🔹 e806e32 🔹 📦 tests package |
igor-sirotin
approved these changes
May 28, 2025
siddarthkay
reviewed
May 28, 2025
yakimant
approved these changes
May 28, 2025
| ifneq ($(detected_OS),Windows) | ||
| SHELL := ./nix/scripts/shell.sh | ||
| # No need for shell.sh script anymore, we use nix develop directly |
There was a problem hiding this comment.
I think we can do that separately, this is already big enough.
| }; | ||
|
|
||
| inputs = { | ||
| nixpkgs.url = "github:NixOS/nixpkgs/df27247e6f3e636c119e2610bf12d38b5e98cc79"; |
There was a problem hiding this comment.
Would be nice to have a comment on this commit hash.
Whats the aim of this pin? Some tools versions?
There was a problem hiding this comment.
The point is that we should be using thet ultimately same nixpkgs commit across zerokit, nim-waku, status-go, and status-desktop, but we might need to align those later.
| inputs = { | ||
| nixpkgs.url = "github:NixOS/nixpkgs/df27247e6f3e636c119e2610bf12d38b5e98cc79"; | ||
| # We cannot do follows since the nim-unwrapped-2_0 doesn't exist in this nixpkgs version above | ||
| nwaku.url = "git+https://github.com/waku-org/nwaku?submodules=1&rev=e755fd834f5f3d6fba216b09469316f0328b3b6f"; |
There was a problem hiding this comment.
How nwaku was downloaded/pinned before?
How it will be synchronised to flake input version?
Would be nice to have a comment on this particular pin.
Is it smth developers need to update? Maybe add to README?
There was a problem hiding this comment.
This is a good question, normally it's done via vendor submodule/commit.
There was a problem hiding this comment.
I can add it in the _docs/how-to-build.md a special section about building with nix and how to update the dependencies(nwaku) to have the CI(I need to add this) always green. But I think here they are adding nwaku as a submodule.
There was a problem hiding this comment.
So in that PR we aren't adding directly nwaku as a submodule, what we did was adding waku-go-bindings as a go module, and when building waku-go-bindings it clones nwaku and builds libwaku
It can definitely be improved, but as an initial implementation it works decently well :)
|
|
||
| ## Resources | ||
|
|
||
| You can learn more about Nix by watching these presentations: | ||
|
|
||
| * [Nix Fundamentals](https://www.youtube.com/watch?v=m4sv2M9jRLg) ([PDF](https://drive.google.com/file/d/1Tt5R7QOubudGiSuZIGxuFWB1OYgcThcL/view?usp=sharing), [src](https://github.com/status-im/infra-docs/tree/master/presentations/nix_basics)) | ||
| * [Nix in Status](https://www.youtube.com/watch?v=rEQ1EvRG8Wc) ([PDF](https://drive.google.com/file/d/1Ti0wppMoj40icCPdHy7mJcQj__DeaYBE/view?usp=sharing), [src](https://github.com/status-im/infra-docs/tree/master/presentations/nix_in_status)) | ||
|
|
||
| And you can read [`nix/DETAILS.md`](./DETAILS.md) for more information. | ||
| * [Nix Flakes](https://wiki.nixos.org/wiki/Flakes) |
There was a problem hiding this comment.
Maybe this also available publicly?
https://docs.infra.status.im/presentations/nix_flakes/content.html
siddarthkay
approved these changes
May 29, 2025
markoburcul
force-pushed
the
add-flake
branch
2 times, most recently
from
f028768 to
88d0d6e
Compare
Expose status-go library, mobile-android and mobile-ios as packages of this flake. Referenced issue: * waku-org/nwaku#3232
Remove old nix commands from Makefile and files from the repo. Adapt Jenkinsfiles to the flake.nix. Update docs for building and nix. Referenced issue: * waku-org/nwaku#3232
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issue:
Creating Nix flake to simplify Nix usage in the repo.
Nix Flake is added with exposed devShells, so a user can type
nix developin the repo root and instantiate a shell or use already existingmake shell.The following packages are exposed: