feat(news)_: hook News settings to the newsFeedManager and its polling #6540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (48)
|
3 tasks
jrainville
force-pushed
the
feat/news-last-fetch
branch
from
5f0ed7b to
b439b63
Compare
jrainville
force-pushed
the
news/hook-settings
branch
from
e62ea86 to
d913c62
Compare
jrainville
force-pushed
the
feat/news-last-fetch
branch
from
b439b63 to
9afcb94
Compare
jrainville
force-pushed
the
news/hook-settings
branch
from
d913c62 to
f96b3da
Compare
|
@igor-sirotin @osmaczko @seanstrom friendly reminder to review |
jrainville
force-pushed
the
feat/news-last-fetch
branch
from
9afcb94 to
93c1e0c
Compare
jrainville
force-pushed
the
news/hook-settings
branch
from
f96b3da to
1902207
Compare
jrainville
force-pushed
the
feat/news-last-fetch
branch
from
93c1e0c to
09fbe78
Compare
jrainville
force-pushed
the
news/hook-settings
branch
from
1902207 to
a89604d
Compare
igor-sirotin
approved these changes
May 7, 2025
| handler FeedHandler | ||
| fetchFrom time.Time | ||
| pollingInterval time.Duration | ||
| polling bool |
There was a problem hiding this comment.
Do we even need the manager, if we're not polling? 🤔
There was a problem hiding this comment.
I thought it would be simpler to start the polling (when the setting is set back up) if the manager is already set up.
Same thing for stopping it.
It just seems like more complex to delete and initialize the whole manager than just stopping the polling.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6540 +/- ##
===========================================
+ Coverage 60.38% 60.43% +0.04%
===========================================
Files 832 832
Lines 103699 103771 +72
===========================================
+ Hits 62623 62712 +89
- Misses 33536 33537 +1
+ Partials 7540 7522 -18
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@igor-sirotin Quick context: Since the RSS comes from a "3rd party", we make sure users can turn it off for privacy reasons. Hence the
In the future, when we'll use Waku instead (using a bot), we'll get rid of the |
osmaczko
approved these changes
May 7, 2025
jrainville
force-pushed
the
news/hook-settings
branch
from
a89604d to
055d25c
Compare
Needed for status-im/status-desktop#17811 Adds the NewsRSSEnabled setting that is going to be used in the Privacy settings of the clients. Adds API methods to toggle the NewsFeedEnabled and NewsRSSEnabled settings. By doing so, it will trigger the NewsFeedManager polling if both settings are set to true. Conversely, if one of them is disabled, it stops the polling.
jrainville
force-pushed
the
news/hook-settings
branch
from
055d25c to
8e95282
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6533
Needed for status-im/status-desktop#17811
Base on top of #6534
Adds the NewsRSSEnabled setting that is going to be used in the Privacy settings of the clients.
Adds API methods to toggle the NewsFeedEnabled and NewsRSSEnabled settings.
By doing so, it will trigger the NewsFeedManager polling if both settings are set to true.
Conversely, if one of them is disabled, it stops the polling.