Chore: Add :screen qualifier to all screens #22413

Parveshdhull · 2025-04-01T09:40:09Z

Testing Note:

PR don't need manual testing, but please run full e2e test suite. (Affects many file, but only rename)

status: ready

status-im-auto · 2025-04-01T09:48:43Z

Jenkins Builds

Click to see older builds (12)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`a681169`	#1	2025-04-01 09:48:43	~8 min	`tests`	📄`log`
✔️	`a681169`	#1	2025-04-01 09:48:48	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`a681169`	#1	2025-04-01 09:49:21	~8 min	`android`	🤖`apk` 📲
✔️	`a681169`	#1	2025-04-01 09:51:09	~10 min	`ios`	📱`ipa` 📲

✔️	`0aa301a`	#2	2025-04-01 09:58:16	~4 min	`tests`	📄`log`
✔️	`0aa301a`	#2	2025-04-01 10:01:40	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`0aa301a`	#2	2025-04-01 10:02:05	~8 min	`android`	🤖`apk` 📲
✔️	`0aa301a`	#2	2025-04-01 10:03:26	~9 min	`ios`	📱`ipa` 📲

✔️	`eadca54`	#3	2025-04-01 10:21:41	~5 min	`tests`	📄`log`
✔️	`eadca54`	#3	2025-04-01 10:24:27	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`eadca54`	#3	2025-04-01 10:26:16	~9 min	`ios`	📱`ipa` 📲
✔️	`eadca54`	#3	2025-04-01 10:26:51	~10 min	`android`	🤖`apk` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`94adeb2`	#4	2025-04-01 10:43:01	~5 min	`tests`	📄`log`
✔️	`94adeb2`	#4	2025-04-01 10:46:05	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`94adeb2`	#4	2025-04-01 10:46:16	~8 min	`android`	🤖`apk` 📲
✔️	`94adeb2`	#4	2025-04-01 10:47:21	~9 min	`ios`	📱`ipa` 📲

✔️	`2d12df1`	#5	2025-04-02 10:22:38	~4 min	`tests`	📄`log`
✔️	`2d12df1`	#5	2025-04-02 10:25:42	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`2d12df1`	#5	2025-04-02 10:25:57	~8 min	`android`	🤖`apk` 📲
✔️	`2d12df1`	#5	2025-04-02 10:28:32	~10 min	`ios`	📱`ipa` 📲

Parveshdhull · 2025-04-02T09:41:13Z

src/legacy/status_im/ui/screens/glossary/view.cljs

Removed unused file

Parveshdhull · 2025-04-02T09:55:25Z

src/status_im/contexts/chat/events.cljs

@@ -99,7 +99,7 @@
             (update :chats-home-list set/difference removed-chats))
     :fx [(when (not-empty removed-chats)
            [:effects/push-notifications-clear-message-notifications removed-chats])
-          (when (and (= view-id :chat) (removed-chats current-chat-id))
+          (when (and (= view-id :screen/chat) (removed-chats current-chat-id))


Most problematic screen name was :chat. Many strings starting with :chat

Parveshdhull · 2025-04-02T09:57:42Z

src/status_im/contexts/communities/overview/view.cljs

-  (let [community-id (or id (rf/sub [:get-screen-params :community-overview]))
+  (let [community-id (or id (quo.context/use-screen-params))


leftover from #22293 (comment)

cc @ulisesmac

Parveshdhull · 2025-04-02T10:00:36Z

src/status_im/contexts/shell/constants.cljs

@@ -2,30 +2,31 @@

 (def ^:const floating-shell-button-height 44)

-(def ^:const default-selected-stack :wallet-stack)
+(def ^:const default-selected-stack :screen/wallet-stack)


The only side effect of this migration is that we store the last selected stack ID in async storage, which will be something like :communities-stack. Since this no longer exists, the selected stack ID will fall back to :screen/wallet-stack for first run after update

Parveshdhull · 2025-04-02T11:46:14Z

Hey @mobile-qa, the PR doesn't need manual testing (just a rename), but could you please run the full E2E suite? It affects a lot of files (82).

status-im-auto · 2025-04-02T11:53:33Z

87% of end-end tests have passed

Total executed tests: 23
Failed tests: 2
Expected to fail tests: 1
Passed tests: 20

IDs of failed tests: 703391,702731

IDs of expected to fail tests: 740490

Failed tests (2)

Click to expand

Rerun failed tests

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_send_image_save_and_share, id: 703391
Device 1: Find `Button` by `accessibility id`: `image-0` Device 1: Click system back button ../views/chat_view.py:751: in send_images_with_description [self.get_image_by_index(i).click() for i in indexes] ../views/chat_view.py:751: in <listcomp> [self.get_image_by_index(i).click() for i in indexes] ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: Button by accessibility id: `image-0` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception During handling of the above exception, another exception occurred: private_chats/test_one_to_one_chat.py:431: in test_1_1_chat_send_image_save_and_share self.chat_1.send_images_with_description(description=image_description, indexes=[0]) ../views/chat_view.py:754: in send_images_with_description pytest.fail("Can't send image(s) with index(es) %s" % indexes) E Failed: Can't send image(s) with index(es) [0] Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_pin_messages, id: 702731
Device 1: Looking for a pinned message by text: Message 4 Device 1: Find `Button` by `xpath`: `//[@content-desc='pinned-messages-menu']//[starts-with(@text,'Message 4')]` private_chats/test_one_to_one_chat.py:267: in test_1_1_chat_pin_messages pinned_message.long_press_without_release() ../views/base_element.py:330: in long_press_without_release action.click_and_hold(self.find_element()).perform() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: Button by xpath: `//[@content-desc='pinned-messages-menu']//[starts-with(@text,'Message 4')]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Expected to fail tests (1)

Click to expand

Class TestWalletOneDevice:

1. test_wallet_balance_mainnet, id: 740490

Device 1: Find Button by accessibility id: network-dropdown
Device 1: Tap on found: Button

wallet/test_wallet_mainnet_no_send.py:71: in test_wallet_balance_mainnet
    self.errors.verify_no_errors()
base_test_case.py:205: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Device 1: For the USD Coin the wrong value 0.0 is shown, expected 5.0 in total
E    Device 1: For the USD Coin the wrong value 0.0 is shown, expected 5.0 on Optimism

[[Might fail due to #22384]]

Device sessions

Device 1:

Steps, video, logs

Passed tests (20)

Click to expand

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_message_send_check_timestamps_sender_username, id: 702838
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_one_image_send_reply_set_reaction, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestWalletOneDevice:

1. test_wallet_swap_flow_mainnet, id: 741555
Device sessions Device 1: Steps, video, logs
2. test_wallet_bridge_flow_mainnet, id: 741612
Device sessions Device 1: Steps, video, logs
3. test_wallet_send_flow_mainnet, id: 741554
Device sessions Device 1: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestWalletCollectibles:

1. test_wallet_send_collectible, id: 741840
Device sessions Device 1: Steps, video, logs
2. test_wallet_collectibles_balance, id: 741839
Device sessions Device 1: Steps, video, logs
3. test_wallet_collectible_send_from_expanded_info_view, id: 741841
Device sessions Device 1: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestWalletOneDeviceTwo:

1. test_wallet_add_remove_regular_account, id: 727231
Device sessions Device 1: Steps, video, logs

Class TestProfileMultipleDevices:

1. test_profile_change_profile_photo, id: 741969
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_profile_change_username, id: 741968
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestWalletMultipleDevice:

1. test_send_eth[Status Network Sepolia-0.0002], id: 727229
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_wallet_send_erc20_from_drawer[Optimism Sepolia-USD Coin-USDC-2-0.01], id: 727230
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_send_eth[Arbitrum Sepolia-0.0001], id: 742015
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_wallet_send_erc20_from_drawer[Sepolia-USD Coin-USDC-2-0.01], id: 742016
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

ulisesmac

Very much needed refactoring! Thank you @Parveshdhull !

ulisesmac · 2025-04-02T21:52:05Z

@Parveshdhull This one should still be addressed: #22388 also a consequence of the new hook

status-github-bot-v2 bot added this to Pipeline for QA Apr 1, 2025

Parveshdhull self-assigned this Apr 1, 2025

status-github-bot-v2 bot moved this to CONTRIBUTOR in Pipeline for QA Apr 1, 2025

Parveshdhull force-pushed the chore/add-screen-qualifier branch from eadca54 to 94adeb2 Compare April 1, 2025 10:37

Parveshdhull added the skip-manual-qa label Apr 1, 2025

Parveshdhull commented Apr 2, 2025

View reviewed changes

src/legacy/status_im/ui/screens/glossary/view.cljs Outdated

Copy link

Member Author

Parveshdhull Apr 2, 2025 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed unused file

Parveshdhull commented Apr 2, 2025

View reviewed changes

Parveshdhull changed the title ~~[WIP]: Chore: Add :screen qualifier to all screens~~ Chore: Add :screen qualifier to all screens Apr 2, 2025

Parveshdhull marked this pull request as ready for review April 2, 2025 10:17

Chore: Add :screen qualifier to all screens

2d12df1

Parveshdhull force-pushed the chore/add-screen-qualifier branch from 94adeb2 to 2d12df1 Compare April 2, 2025 10:17

Parveshdhull requested review from ilmotta, flexsurfer and ulisesmac April 2, 2025 10:17

flexsurfer approved these changes Apr 2, 2025

View reviewed changes

flexsurfer moved this from CONTRIBUTOR to E2E Tests in Pipeline for QA Apr 2, 2025

ulisesmac approved these changes Apr 2, 2025

View reviewed changes

Parveshdhull merged commit e42087a into develop Apr 3, 2025
4 of 5 checks passed

Parveshdhull deleted the chore/add-screen-qualifier branch April 3, 2025 12:12

github-project-automation bot moved this from E2E Tests to DONE in Pipeline for QA Apr 3, 2025

Parveshdhull mentioned this pull request Apr 24, 2025

Allow user to unpin messages straight from pinned messages drawer #22497

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Chore: Add :screen qualifier to all screens #22413

Chore: Add :screen qualifier to all screens #22413

Parveshdhull commented Apr 1, 2025 •

edited

Loading

status-im-auto commented Apr 1, 2025 •

edited

Loading

Parveshdhull Apr 2, 2025 •

edited

Loading

Parveshdhull Apr 2, 2025 •

edited

Loading

Parveshdhull Apr 2, 2025

Parveshdhull Apr 2, 2025

Parveshdhull Apr 2, 2025 •

edited

Loading

Parveshdhull commented Apr 2, 2025

status-im-auto commented Apr 2, 2025

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestWalletOneDevice:

Class TestCommunityOneDeviceMerged:

Class TestCommunityMultipleDeviceMerged:

Class TestWalletOneDevice:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestWalletCollectibles:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestWalletOneDeviceTwo:

Class TestProfileMultipleDevices:

Class TestWalletMultipleDevice:

ulisesmac left a comment

ulisesmac commented Apr 2, 2025

		(let [community-id (or id (rf/sub [:get-screen-params :community-overview]))
		(let [community-id (or id (quo.context/use-screen-params))

Chore: Add :screen qualifier to all screens #22413

Chore: Add :screen qualifier to all screens #22413

Conversation

Parveshdhull commented Apr 1, 2025 • edited Loading

Testing Note:

status-im-auto commented Apr 1, 2025 • edited Loading

Jenkins Builds

Parveshdhull Apr 2, 2025 • edited Loading

Choose a reason for hiding this comment

Parveshdhull Apr 2, 2025 • edited Loading

Choose a reason for hiding this comment

Parveshdhull Apr 2, 2025

Choose a reason for hiding this comment

Parveshdhull Apr 2, 2025

Choose a reason for hiding this comment

Parveshdhull Apr 2, 2025 • edited Loading

Choose a reason for hiding this comment

Parveshdhull commented Apr 2, 2025

status-im-auto commented Apr 2, 2025

87% of end-end tests have passed

Failed tests (2)

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Expected to fail tests (1)

Class TestWalletOneDevice:

Passed tests (20)

Class TestCommunityOneDeviceMerged:

Class TestCommunityMultipleDeviceMerged:

Class TestWalletOneDevice:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestWalletCollectibles:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestWalletOneDeviceTwo:

Class TestProfileMultipleDevices:

Class TestWalletMultipleDevice:

ulisesmac left a comment

Choose a reason for hiding this comment

ulisesmac commented Apr 2, 2025

Parveshdhull commented Apr 1, 2025 •

edited

Loading

status-im-auto commented Apr 1, 2025 •

edited

Loading

Parveshdhull Apr 2, 2025 •

edited

Loading

Parveshdhull Apr 2, 2025 •

edited

Loading

Parveshdhull Apr 2, 2025 •

edited

Loading